Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 2867693004: Snapshot of all changes to get jumbo in blink and content.
Patch Set: Rebased again Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tracing/tracing_controller_impl.cc
diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc
index e3b447c98134010da4bbe80829f2460579c613af..8fba03cd073e2ca65371c0ab533b800ef8655b5c 100644
--- a/content/browser/tracing/tracing_controller_impl.cc
+++ b/content/browser/tracing/tracing_controller_impl.cc
@@ -67,12 +67,12 @@ namespace content {
namespace {
-base::LazyInstance<TracingControllerImpl>::Leaky g_controller =
+base::LazyInstance<TracingControllerImpl>::Leaky g_tracing_controller =
LAZY_INSTANCE_INITIALIZER;
const char kChromeTracingAgentName[] = "chrome";
-const char kETWTracingAgentName[] = "etw";
-const char kArcTracingAgentName[] = "arc";
+const char kETWTracingAgentNameCopy[] = "etw";
+const char kArcTracingAgentNameCopy[] = "arc";
const char kChromeTraceLabel[] = "traceEvents";
const int kStartTracingTimeoutSeconds = 30;
@@ -146,7 +146,7 @@ TracingControllerImpl::~TracingControllerImpl() {
}
TracingControllerImpl* TracingControllerImpl::GetInstance() {
- return g_controller.Pointer();
+ return g_tracing_controller.Pointer();
}
bool TracingControllerImpl::GetCategories(
@@ -474,7 +474,7 @@ void TracingControllerImpl::AddTracingAgent(const std::string& agent_name) {
return;
}
- if (agent_name == kArcTracingAgentName) {
+ if (agent_name == kArcTracingAgentNameCopy) {
additional_tracing_agents_.push_back(ArcTracingAgent::GetInstance());
return;
}
@@ -582,11 +582,11 @@ void TracingControllerImpl::OnEndAgentTracingAcked(
if (trace_data_sink_.get() && events_str_ptr &&
!events_str_ptr->data().empty()) {
- if (agent_name == kETWTracingAgentName) {
+ if (agent_name == kETWTracingAgentNameCopy) {
// The Windows kernel events are kept into a JSON format stored as string
// and must not be escaped.
trace_data_sink_->AddAgentTrace(events_label, events_str_ptr->data());
- } else if (agent_name == kArcTracingAgentName) {
+ } else if (agent_name == kArcTracingAgentNameCopy) {
// The ARC events are kept into a JSON format stored as string
// and must not be escaped.
trace_data_sink_->AddTraceChunk(events_str_ptr->data());
« no previous file with comments | « content/browser/speech/endpointer/endpointer.cc ('k') | content/browser/tracing/tracing_controller_impl_data_sinks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698