Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1915)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 2867693004: Snapshot of all changes to get jumbo in blink and content.
Patch Set: Rebased again Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc
index cf3c4cab2e8c4070f06b2a42eee62e469abeda1d..a623f7d2ba21356d7c7f474616ad52597a3cfbcb 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest.cc
@@ -126,7 +126,7 @@ BrowserPluginGuest::BrowserPluginGuest(bool has_render_view,
weak_ptr_factory_(this) {
DCHECK(web_contents);
DCHECK(delegate);
- RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.Create"));
+ base::RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.Create"));
web_contents->SetBrowserPluginGuest(this);
delegate->SetGuestHost(this);
}
@@ -684,7 +684,8 @@ void BrowserPluginGuest::SendTextInputTypeChangedToView(
void BrowserPluginGuest::DidFinishNavigation(
NavigationHandle* navigation_handle) {
if (navigation_handle->HasCommitted())
- RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.DidNavigate"));
+ base::RecordAction(
+ base::UserMetricsAction("BrowserPlugin.Guest.DidNavigate"));
}
void BrowserPluginGuest::RenderViewReady() {
@@ -720,17 +721,19 @@ void BrowserPluginGuest::RenderProcessGone(base::TerminationStatus status) {
case base::TERMINATION_STATUS_PROCESS_WAS_KILLED_BY_OOM:
#endif
case base::TERMINATION_STATUS_PROCESS_WAS_KILLED:
- RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.Killed"));
+ base::RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.Killed"));
break;
case base::TERMINATION_STATUS_PROCESS_CRASHED:
- RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.Crashed"));
+ base::RecordAction(
+ base::UserMetricsAction("BrowserPlugin.Guest.Crashed"));
break;
case base::TERMINATION_STATUS_ABNORMAL_TERMINATION:
- RecordAction(
+ base::RecordAction(
base::UserMetricsAction("BrowserPlugin.Guest.AbnormalDeath"));
break;
case base::TERMINATION_STATUS_LAUNCH_FAILED:
- RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.LaunchFailed"));
+ base::RecordAction(
+ base::UserMetricsAction("BrowserPlugin.Guest.LaunchFailed"));
break;
default:
break;
@@ -851,7 +854,7 @@ void BrowserPluginGuest::OnWillAttachComplete(
rwhv->RegisterFrameSinkId();
has_render_view_ = true;
- RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.Attached"));
+ base::RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.Attached"));
}
void BrowserPluginGuest::OnDetach(int browser_plugin_instance_id) {

Powered by Google App Engine
This is Rietveld 408576698