Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: content/browser/appcache/appcache_update_job.cc

Issue 2867693004: Snapshot of all changes to get jumbo in blink and content.
Patch Set: Rebased again Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_update_job.cc
diff --git a/content/browser/appcache/appcache_update_job.cc b/content/browser/appcache/appcache_update_job.cc
index ec16a5a27f2b93063f5328dc850371a7c1ef7ec5..f5190c023e8a1d4eb469cc5f0a2aa5aad2b759e8 100644
--- a/content/browser/appcache/appcache_update_job.cc
+++ b/content/browser/appcache/appcache_update_job.cc
@@ -29,7 +29,7 @@ namespace content {
namespace {
-const int kBufferSize = 32768;
+const int kAppCacheFetchBufferSize = 32768;
const size_t kMaxConcurrentUrlFetches = 2;
const int kMax503Retries = 3;
@@ -188,7 +188,7 @@ AppCacheUpdateJob::URLFetcher::URLFetcher(const GURL& url,
job_(job),
fetch_type_(fetch_type),
retry_503_attempts_(0),
- buffer_(new net::IOBuffer(kBufferSize)),
+ buffer_(new net::IOBuffer(kAppCacheFetchBufferSize)),
request_(
job->service_->request_context()->CreateRequest(url,
net::DEFAULT_PRIORITY,
@@ -303,7 +303,7 @@ void AppCacheUpdateJob::URLFetcher::OnReadCompleted(
data_consumed = ConsumeResponseData(bytes_read);
if (data_consumed) {
while (true) {
- bytes_read = request->Read(buffer_.get(), kBufferSize);
+ bytes_read = request->Read(buffer_.get(), kAppCacheFetchBufferSize);
if (bytes_read <= 0)
break;
data_consumed = ConsumeResponseData(bytes_read);
@@ -360,7 +360,7 @@ void AppCacheUpdateJob::URLFetcher::ReadResponseData() {
InternalUpdateState state = job_->internal_state_;
if (state == CACHE_FAILURE || state == CANCELLED || state == COMPLETED)
return;
- int bytes_read = request_->Read(buffer_.get(), kBufferSize);
+ int bytes_read = request_->Read(buffer_.get(), kAppCacheFetchBufferSize);
if (bytes_read != net::ERR_IO_PENDING)
OnReadCompleted(request_.get(), bytes_read);
}
@@ -1208,10 +1208,10 @@ void AppCacheUpdateJob::CheckIfManifestChanged() {
manifest_response_reader_.reset(
storage_->CreateResponseReader(manifest_url_,
entry->response_id()));
- read_manifest_buffer_ = new net::IOBuffer(kBufferSize);
+ read_manifest_buffer_ = new net::IOBuffer(kAppCacheFetchBufferSize);
manifest_response_reader_->ReadData(
read_manifest_buffer_.get(),
- kBufferSize,
+ kAppCacheFetchBufferSize,
base::Bind(&AppCacheUpdateJob::OnManifestDataReadComplete,
base::Unretained(this))); // async read
}
@@ -1221,7 +1221,7 @@ void AppCacheUpdateJob::OnManifestDataReadComplete(int result) {
loaded_manifest_data_.append(read_manifest_buffer_->data(), result);
manifest_response_reader_->ReadData(
read_manifest_buffer_.get(),
- kBufferSize,
+ kAppCacheFetchBufferSize,
base::Bind(&AppCacheUpdateJob::OnManifestDataReadComplete,
base::Unretained(this))); // read more
} else {
« no previous file with comments | « content/browser/appcache/appcache_storage_impl.cc ('k') | content/browser/blob_storage/chrome_blob_storage_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698