chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc - Issue 2867673004: Use OnceCallback on Mojo interfaces in //ash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

Issue 2867673004: Use OnceCallback on Mojo interfaces in //ash (Closed)

Patch Set: count -> container_count Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc ('k') | chrome/browser/ui/ash/session_controller_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

index 72b53193de729d52ec20b193963c958263039d68..57ba5a5dbd456f2031d9cf26443728ac1ea94074 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

@@ -264,8 +264,8 @@ class TestV2AppLauncherItemController : public ash::ShelfItemDelegate {

void ItemSelected(std::unique_ptr<ui::Event> event,

int64_t display_id,

ash::ShelfLaunchSource source,

- const ItemSelectedCallback& callback) override {

- callback.Run(ash::SHELF_ACTION_WINDOW_ACTIVATED, base::nullopt);

+ ItemSelectedCallback callback) override {

+ std::move(callback).Run(ash::SHELF_ACTION_WINDOW_ACTIVATED, base::nullopt);

}

void ExecuteCommand(uint32_t command_id, int32_t event_flags) override {}

void Close() override {}