Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: chrome/browser/resources/settings/printing_page/cups_printers.html

Issue 2867563002: [CUPS] Modify the "Add Printer" link to a button. (Closed)
Patch Set: Address michaelpg@'s comment. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/action_link.html"> 1 <link rel="import" href="chrome://resources/html/action_link.html">
2 <link rel="import" href="chrome://resources/html/action_link_css.html"> 2 <link rel="import" href="chrome://resources/html/action_link_css.html">
3 <link rel="import" href="chrome://resources/html/assert.html"> 3 <link rel="import" href="chrome://resources/html/assert.html">
4 <link rel="import" href="chrome://resources/html/cr/ui/focus_without_ink.html"> 4 <link rel="import" href="chrome://resources/html/cr/ui/focus_without_ink.html">
5 <link rel="import" href="chrome://resources/html/polymer.html"> 5 <link rel="import" href="chrome://resources/html/polymer.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
6 <link rel="import" href="cups_add_printer_dialog.html"> 7 <link rel="import" href="cups_add_printer_dialog.html">
7 <link rel="import" href="cups_printers_list.html"> 8 <link rel="import" href="cups_printers_list.html">
8 <link rel="import" href="../settings_shared_css.html"> 9 <link rel="import" href="../settings_shared_css.html">
9 10
10 <dom-module id="settings-cups-printers"> 11 <dom-module id="settings-cups-printers">
11 <template> 12 <template>
12 <style include="settings-shared action-link"> 13 <style include="settings-shared action-link">
13 .settings-box .start { 14 .settings-box .start {
14 color: var(--paper-grey-600); 15 color: var(--paper-grey-600);
15 } 16 }
16 17
17 .settings-box .start .secondary { 18 .settings-box .start .secondary {
18 color: var(--paper-grey-800); 19 color: var(--paper-grey-800);
19 font-size: 92.31%; /* 12px / 13px */ 20 font-size: 92.31%; /* 12px / 13px */
20 } 21 }
22
23 .settings-box .primary-button {
24 -webkit-margin-end: 0;
25 -webkit-margin-start: auto;
26 }
21 27
22 #message { 28 #message {
23 display: flex; 29 display: flex;
24 justify-content: center; 30 justify-content: center;
25 position: absolute; 31 position: absolute;
26 top: 85%; 32 top: 85%;
27 width: 100%; 33 width: 100%;
28 } 34 }
29 35
30 .center { 36 .center {
(...skipping 10 matching lines...) Expand all
41 display: flex; 47 display: flex;
42 justify-content: space-around; 48 justify-content: space-around;
43 } 49 }
44 50
45 #addPrinterErrorMessage a[is='action-link'] { 51 #addPrinterErrorMessage a[is='action-link'] {
46 text-transform: uppercase; 52 text-transform: uppercase;
47 } 53 }
48 </style> 54 </style>
49 55
50 <div class="settings-box first"> 56 <div class="settings-box first">
51 <a id="addPrinter" is="action-link" on-tap="onAddPrinterTap_" 57 <paper-button class="primary-button" id="addPrinter"
52 hidden="[[!canAddPrinter_]]"> 58 on-tap="onAddPrinterTap_" hidden="[[!canAddPrinter_]]">
53 $i18n{addCupsPrinter} 59 $i18n{addCupsPrinter}
54 </a> 60 </paper-button>
55 <div class="start" hidden="[[canAddPrinter_]]"> 61 <div class="start" hidden="[[canAddPrinter_]]">
56 <span>$i18n{addCupsPrinter}</span> 62 <span>$i18n{addCupsPrinter}</span>
57 <div class="secondary"> 63 <div class="secondary">$i18n{requireNetworkMessage}</div>
58 $i18n{requireNetworkMessage}
59 </div>
60 </div> 64 </div>
61 </div> 65 </div>
62 66
63 <settings-cups-add-printer-dialog id="addPrinterDialog" 67 <settings-cups-add-printer-dialog id="addPrinterDialog"
64 on-close="onAddPrinterDialogClose_"> 68 on-close="onAddPrinterDialogClose_">
65 </settings-cups-add-printer-dialog> 69 </settings-cups-add-printer-dialog>
66 70
67 <settings-cups-printers-list printers="{{printers}}" 71 <settings-cups-printers-list printers="{{printers}}"
68 search-term="[[searchTerm]]"> 72 search-term="[[searchTerm]]">
69 </settings-cups-printers-list> 73 </settings-cups-printers-list>
70 74
71 <div id="message"> 75 <div id="message">
72 <div class="center" id="addPrinterDoneMessage" hidden> 76 <div class="center" id="addPrinterDoneMessage" hidden>
73 $i18n{printerAddedSuccessfulMessage} 77 $i18n{printerAddedSuccessfulMessage}
74 </div> 78 </div>
75 <div class="center" id="addPrinterErrorMessage" hidden> 79 <div class="center" id="addPrinterErrorMessage" hidden>
76 <span>$i18n{printerAddedFailedMessage}</span> 80 <span>$i18n{printerAddedFailedMessage}</span>
77 <a is="action-link" on-tap="onAddPrinterTap_"> 81 <a is="action-link" on-tap="onAddPrinterTap_">
78 $i18n{printerAddedTryAgainMessage} 82 $i18n{printerAddedTryAgainMessage}
79 </a> 83 </a>
80 </div> 84 </div>
81 </div> 85 </div>
82 </template> 86 </template>
83 <script src="cups_printers.js"></script> 87 <script src="cups_printers.js"></script>
84 </dom-module> 88 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698