ui/views/widget/widget_hwnd_utils.cc - Issue 286733002: [Refactor] Consolidate the logic for whether a widget can be activated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/widget_hwnd_utils.cc

Issue 286733002: [Refactor] Consolidate the logic for whether a widget can be activated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/widget_hwnd_utils.cc

diff --git a/ui/views/widget/widget_hwnd_utils.cc b/ui/views/widget/widget_hwnd_utils.cc

index 40ccd29552927dc8837be01c5bfef377a3acbfb5..30e41088f2c6f26a2bcf0675ef4dcfc54505435d 100644

--- a/ui/views/widget/widget_hwnd_utils.cc

+++ b/ui/views/widget/widget_hwnd_utils.cc

@@ -41,7 +41,8 @@ void CalculateWindowStylesFromInitParams(

*style |= WS_MINIMIZE;

if (!params.accept_events)

*ex_style |= WS_EX_TRANSPARENT;

- if (!params.can_activate)

+ DCHECK_NE(Widget::InitParams::ACTIVATABLE_DEFAULT, params.activatable);

+ if (params.activatable == Widget::InitParams::ACTIVATABLE_NO)

*ex_style |= WS_EX_NOACTIVATE;

if (params.keep_on_top)

*ex_style |= WS_EX_TOPMOST;

« no previous file with comments | « ui/views/widget/widget.cc ('k') | ui/views/widget/widget_unittest.cc » ('j') | no next file with comments »