chrome/browser/first_run/try_chrome_dialog_view.cc - Issue 286733002: [Refactor] Consolidate the logic for whether a widget can be activated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/try_chrome_dialog_view.cc

Issue 286733002: [Refactor] Consolidate the logic for whether a widget can be activated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/ui/idle_app_name_notification_view.cc ('k') | chrome/browser/ui/views/fullscreen_exit_bubble_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/first_run/try_chrome_dialog_view.cc

diff --git a/chrome/browser/first_run/try_chrome_dialog_view.cc b/chrome/browser/first_run/try_chrome_dialog_view.cc

index 04d32b83e2a30ef88169ad0c525923cddc560967..ff4bb0b4ed0fe464954c524cd09d979c4d10fdea 100644

--- a/chrome/browser/first_run/try_chrome_dialog_view.cc

+++ b/chrome/browser/first_run/try_chrome_dialog_view.cc

@@ -86,7 +86,7 @@ TryChromeDialogView::Result TryChromeDialogView::ShowModal(

// An approximate window size. After Layout() we'll get better bounds.

views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);

- params.can_activate = true;

+ params.activatable = views::Widget::InitParams::ACTIVATABLE_YES;

params.bounds = gfx::Rect(310, 200);

popup_ = new views::Widget;

popup_->Init(params);