base/metrics/sparse_histogram.h - Issue 2867303004: [histogram] Make histograms more resistant to overflows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/sparse_histogram.h

Issue 2867303004: [histogram] Make histograms more resistant to overflows. (Closed)

Patch Set: final final fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/sparse_histogram.h

diff --git a/base/metrics/sparse_histogram.h b/base/metrics/sparse_histogram.h

index 97709ba18f0568feb77cb29d964948fdf2bf2de2..66e9825918d967f7298e6d82eb18992fdfae660f 100644

--- a/base/metrics/sparse_histogram.h

+++ b/base/metrics/sparse_histogram.h

@@ -97,7 +97,7 @@ class BASE_EXPORT SparseHistogram : public HistogramBase {

// Flag to indicate if PrepareFinalDelta has been previously called.

mutable bool final_delta_created_ = false;

- std::unique_ptr<HistogramSamples> samples_;

+ std::unique_ptr<HistogramSamples> unlogged_samples_;

std::unique_ptr<HistogramSamples> logged_samples_;

DISALLOW_COPY_AND_ASSIGN(SparseHistogram);

« no previous file with comments | « base/metrics/histogram_unittest.cc ('k') | base/metrics/sparse_histogram.cc » ('j') | no next file with comments »