base/metrics/histogram_base.h - Issue 2867303004: [histogram] Make histograms more resistant to overflows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_base.h

Issue 2867303004: [histogram] Make histograms more resistant to overflows. (Closed)

Patch Set: final final fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_base.h

diff --git a/base/metrics/histogram_base.h b/base/metrics/histogram_base.h

index 4f5ba049bc6943c5c2454ac407b2a52fa9c67d83..3c6e136eb777b114fe6f0d887f3c9b3dd6459eae 100644

--- a/base/metrics/histogram_base.h

+++ b/base/metrics/histogram_base.h

@@ -187,6 +187,9 @@ class BASE_EXPORT HistogramBase {

// Snapshot the current complete set of sample data.

// Override with atomic/locked snapshot if needed.

+ // NOTE: this data can overflow for long-running sessions. It should be

+ // handled with care and this method is recommended to be used only

+ // in about:histograms and test code.

virtual std::unique_ptr<HistogramSamples> SnapshotSamples() const = 0;

// Calculate the change (delta) in histogram counts since the previous call

« no previous file with comments | « base/metrics/histogram.cc ('k') | base/metrics/histogram_unittest.cc » ('j') | no next file with comments »