[histogram] Make histograms more resistant to overflows.

base/metrics/histogram_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/histogram.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 383 matching lines @@
   histogram->AddCount(200000000, 25);
   histogram->AddCount(300000000, 24);
 
   std::unique_ptr<HistogramSamples> samples2 = histogram->SnapshotSamples();
   EXPECT_EQ(78, samples2->TotalCount());
   EXPECT_EQ(40, samples2->GetCount(200000000));
   EXPECT_EQ(38, samples2->GetCount(300000000));
   EXPECT_EQ(19400000000LL, samples2->sum());
 }
 
+TEST_P(HistogramTest, AddCount_LargeCountsDontOverflow) {

[Ilya Sherman, 2017/05/09 22:15:32]

Please add a comment documenting what this is intending to test.  In particular,
it should be clear to someone reading this test that ten calls to AddCount(42, 1
<< 30) without an intervening call to SnapshotDelta() should be expected to
overflow.

[altimin, 2017/05/10 11:50:38]

Done.

+  const size_t kBucketCount = 50;
+  Histogram* histogram = static_cast<Histogram*>(
+      Histogram::FactoryGet("AddCountHistogram", 10, 1000000000, kBucketCount,

[Ilya Sherman, 2017/05/09 22:15:32]

nit: Do you need such a large max bucket value?  It's a bit hard to read and
distracting from the rest of the test.

[altimin, 2017/05/10 11:50:38]

Done.

+                            HistogramBase::kNoFlags));
+
+  // Repeat N times to make sure that there is no internal value overflow.
+  for (int i = 0; i < 10; ++i) {
+    histogram->AddCount(42, 1 << 30);
+    std::unique_ptr<HistogramSamples> samples = histogram->SnapshotDelta();
+    EXPECT_EQ(1 << 30, samples->TotalCount());
+    EXPECT_EQ(1 << 30, samples->GetCount(42));
+  }
+}
+
 // Make sure histogram handles out-of-bounds data gracefully.
 TEST_P(HistogramTest, BoundsTest) {
   const size_t kBucketCount = 50;
   Histogram* histogram = static_cast<Histogram*>(
       Histogram::FactoryGet("Bounded", 10, 100, kBucketCount,
                             HistogramBase::kNoFlags));
 
   // Put two samples "out of bounds" above and below.
   histogram->Add(5);
   histogram->Add(-50);
@@ skipping 329 matching lines @@
   // CustomHistogram needs at least 1 valid range.
   custom_ranges.clear();
   custom_ranges.push_back(0);
   EXPECT_DEATH_IF_SUPPORTED(
       CustomHistogram::FactoryGet("BadRangesCustom3", custom_ranges,
                                   HistogramBase::kNoFlags),
                "");
 }
 
 }  // namespace base