FileState needs only bytes of the file.

FileState needs only bytes of the file.

R=paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/f0b6ded6047714e60811fcf7b950e94e948d001b

[Paul Berry, 2017-05-09 12:38:21]

lgtm

https://codereview.chromium.org/2867303002/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental/file_state.dart (right):

https://codereview.chromium.org/2867303002/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:217: throw new StateError('The
method should not be invoked.');
Can we include a comment here so that in case someone runs across this error in
the future they know why it happened?

E.g. something like:

"_FileSystemViewEntry is used by the incremental kernel generator to provide
Fasta with a consistent, race condition free view of the files constituting the
project.  It should only need to be used for reading file contents."

[scheglov, 2017-05-09 16:20:08]

https://codereview.chromium.org/2867303002/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental/file_state.dart (right):

https://codereview.chromium.org/2867303002/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:217: throw new StateError('The
method should not be invoked.');
On 2017/05/09 12:38:21, Paul Berry wrote:
> Can we include a comment here so that in case someone runs across this error
in
> the future they know why it happened?
> 
> E.g. something like:
> 
> "_FileSystemViewEntry is used by the incremental kernel generator to provide
> Fasta with a consistent, race condition free view of the files constituting
the
> project.  It should only need to be used for reading file contents."

Done.

[scheglov, 2017-05-09 16:20:56]

Description was changed from

==========
FileState needs only bytes of the file.

R=paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
FileState needs only bytes of the file.

R=paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/f0b6ded6047714e60811fcf7b950e94e948d001b
==========

[scheglov, 2017-05-09 16:20:57]

Committed patchset #2 (id:20001) manually as
f0b6ded6047714e60811fcf7b950e94e948d001b (presubmit successful).