Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

Issue 2867293002: [LayoutNG] Compute baseline from fragment tree (Closed)
Patch Set: Cleanup Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
index f8cc737256746d1dc8dccb1b1ea71eca21d57307..edf3598f0f9c165e62563e049e9b4d4ca4961d4b 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
@@ -4,6 +4,7 @@
#include "core/layout/ng/ng_fragment_builder.h"
+#include "core/layout/ng/inline/ng_physical_line_box_fragment.h"
#include "core/layout/ng/inline/ng_physical_text_fragment.h"
#include "core/layout/ng/ng_block_break_token.h"
#include "core/layout/ng/ng_block_node.h"
@@ -192,6 +193,12 @@ NGFragmentBuilder& NGFragmentBuilder::AddOutOfFlowDescendant(
return *this;
}
+void NGFragmentBuilder::AddBaseline(NGBaselineAlgorithmType algorithm_type,
+ FontBaseline baseline_type,
+ LayoutUnit offset) {
+ baselines_.push_back(NGBaseline{algorithm_type, baseline_type, offset});
+}
+
RefPtr<NGLayoutResult> NGFragmentBuilder::ToBoxFragment() {
DCHECK_EQ(type_, NGPhysicalFragment::kFragmentBox);
DCHECK_EQ(offsets_.size(), children_.size());
@@ -229,8 +236,8 @@ RefPtr<NGLayoutResult> NGFragmentBuilder::ToBoxFragment() {
RefPtr<NGPhysicalBoxFragment> fragment = AdoptRef(new NGPhysicalBoxFragment(
layout_object_, physical_size, overflow_.ConvertToPhysical(writing_mode_),
- children_, positioned_floats_, border_edges_.ToPhysical(writing_mode_),
- std::move(break_token)));
+ children_, positioned_floats_, baselines_,
+ border_edges_.ToPhysical(writing_mode_), std::move(break_token)));
return AdoptRef(
new NGLayoutResult(std::move(fragment), oof_positioned_descendants_,

Powered by Google App Engine
This is Rietveld 408576698