Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Unified Diff: third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc

Issue 2867293002: [LayoutNG] Compute baseline from fragment tree (Closed)
Patch Set: Cleanup Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc b/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
index f50fa2c36bc1cae4a490f46ed9935f46e78d3123..68dcf1d9d2ef662ea15424579646ea9412cf7540 100644
--- a/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
+++ b/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
@@ -55,4 +55,17 @@ void LayoutNGBlockFlow::ResetNGInlineNodeData() {
ng_inline_node_data_ = WTF::MakeUnique<NGInlineNodeData>();
}
+int LayoutNGBlockFlow::FirstLineBoxBaseline() const {
+ // TODO(kojii): Implement. This will stop working once we stop creating line
+ // boxes.
+ return LayoutBlockFlow::FirstLineBoxBaseline();
+}
+
+int LayoutNGBlockFlow::InlineBlockBaseline(
+ LineDirectionMode line_direction) const {
+ // TODO(kojii): Implement. This will stop working once we stop creating line
+ // boxes.
+ return LayoutBlockFlow::InlineBlockBaseline(line_direction);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698