Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2867253004: Fix annotation of generic method invocations in Fasta inference tests. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix annotation of generic method invocations in Fasta inference tests. Note that one Fasta test starts failing as a result of this change, due to the fact that the Fasta type inference logic is not yet complete. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/c8026439dc59f3d22ba7f6af074b9cf9e6819ab0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -228 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 3 chunks +32 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_basic.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_lub.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_no_return.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downward_inference_fixes_no_upwards_errors.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_function_of_t_using_the_t.dart View 1 chunk +7 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/future_or_subtyping.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then.dart View 1 chunk +13 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_2.dart View 1 chunk +13 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_3.dart View 1 chunk +13 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_4.dart View 1 chunk +13 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_5.dart View 1 chunk +13 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_6.dart View 1 chunk +13 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_2.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_3.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_4.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_5.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_6.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_downwards_method_target.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_explicit_future.dart View 1 chunk +7 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_upwards.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_upwards_2.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_upwards_3.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_upwards_from_block.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_2.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_3.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_4.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_future_return.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_generic_return.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/future_union_upwards_generic_methods.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_functions_return_typedef.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_basic_downward_inference.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_correctly_recognize_generic_upper_bound.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_dart_math_min_max.dart View 1 chunk +14 lines, -10 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_downwards_inference_affects_arguments.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_downwards_inference_fold.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_method_type.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_inference_error.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart View 1 chunk +31 lines, -25 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_nested_generic_instantiation.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_uses_greatest_lower_bound.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_generic_method_type_named.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_generic_method_type_positional.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_generic_method_type_positional2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_generic_method_type_required.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_return_of_statement_lambda.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/lambda_does_not_have_propagated_type_hint.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_instance_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_instance_method_identifier_sequence.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_static_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_top_level_function.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_implicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_dynamic_param.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_type_param.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_implicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/void_return_type_subtypes_dynamic.dart View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-09 22:13:06 UTC) #2
danrubel
LGTM
3 years, 7 months ago (2017-05-09 22:21:43 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as c8026439dc59f3d22ba7f6af074b9cf9e6819ab0 (presubmit successful).
3 years, 7 months ago (2017-05-09 22:25:26 UTC) #5
scheglov
3 years, 7 months ago (2017-05-09 23:27:04 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698