Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java

Issue 2867183002: [Home] Fix bottom offset for native pages (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java b/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
index 67a52efa322092ec4bc0ce57ae934dacfe7fcbe0..46d71037cfdfd783ba2fdfb7d15f3b74f0628603 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
@@ -36,17 +36,19 @@ public abstract class BasicNativePage implements NativePage {
Resources res = mActivity.getResources();
+ int topMargin = 0;
+ int bottomMargin = 0;
if (activity instanceof ChromeActivity
&& ((ChromeActivity) activity).getBottomSheet() != null) {
- return;
+ bottomMargin = res.getDimensionPixelSize(R.dimen.bottom_control_container_height);
+ } else {
+ topMargin = res.getDimensionPixelSize(R.dimen.tab_strip_height)
+ + res.getDimensionPixelSize(R.dimen.toolbar_height_no_shadow);
}
LayoutParams layoutParams = new LayoutParams(LayoutParams.MATCH_PARENT,
LayoutParams.MATCH_PARENT);
- layoutParams.setMargins(0,
- res.getDimensionPixelSize(R.dimen.tab_strip_height)
- + res.getDimensionPixelSize(R.dimen.toolbar_height_no_shadow),
- 0, 0);
+ layoutParams.setMargins(0, topMargin, 0, bottomMargin);
getView().setLayoutParams(layoutParams);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698