Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

Issue 2867133002: DevTools: Let the drawer tabs be reordered (Closed)
Patch Set: showView Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
index 2004274fc38410a9cf407d6fb0beadc139b502fb..f2377680c375431d733d1d3932f095a81f76fced 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
@@ -816,7 +816,7 @@ UI.TabbedPane = class extends UI.VBox {
* @param {number} index
*/
_insertBefore(tab, index) {
- this._tabsElement.insertBefore(tab._tabElement || null, this._tabsElement.childNodes[index]);
+ this._tabsElement.insertBefore(tab.tabElement, this._tabsElement.childNodes[index]);
var oldIndex = this._tabs.indexOf(tab);
this._tabs.splice(oldIndex, 1);
if (oldIndex < index)
@@ -1081,7 +1081,6 @@ UI.TabbedPaneTab = class {
tabElement.id = 'tab-' + this._id;
UI.ARIAUtils.markAsTab(tabElement);
UI.ARIAUtils.setSelected(tabElement, false);
- tabElement.selectTabForTest = this._tabbedPane.selectTab.bind(this._tabbedPane, this.id, true);
var titleElement = tabElement.createChild('span', 'tabbed-pane-header-tab-title');
titleElement.textContent = this.title;

Powered by Google App Engine
This is Rietveld 408576698