DevTools: Let the drawer tabs be reordered

third_party/WebKit/Source/devtools/front_end/ui/View.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @interface
  */
 UI.View = function() {};
 
 UI.View.prototype = {
   /**
@@ skipping 658 matching lines @@
   }
 
   /**
    * @param {!UI.View} view
    * @param {number=} index
    */
   _appendTab(view, index) {
     this._tabbedPane.appendTab(
         view.viewId(), view.title(), new UI.ViewManager._ContainerWidget(view), undefined, false,
         view.isCloseable() || view.isTransient(), index);
+    if (view.isCloseable()) {

[dgozman, 2017/05/25 17:12:49]

Let's move this persisting block to appendView instead? There is no need to call
it from appendApplicableItems.

[einbinder, 2017/05/25 23:48:54]

Done.

+      var tabs = this._closeableTabSetting.get();
+      var tabId = view.viewId();
+      if (!tabs[tabId]) {
+        tabs[tabId] = true;
+        this._closeableTabSetting.set(tabs);
+      }
+    }
+    this._persistTabOrder();
   }
 
   /**
    * @override
    * @param {!UI.View} view
    * @param {?UI.View=} insertBefore
    */
   appendView(view, insertBefore) {
     if (this._tabbedPane.hasTab(view.viewId()))
       return;
@@ skipping 52 matching lines @@
     this._tabbedPane.closeTab(view.viewId());
   }
 
   /**
    * @param {!Common.Event} event
    */
   _tabSelected(event) {
     var tabId = /** @type {string} */ (event.data.tabId);
     if (this._lastSelectedTabSetting && event.data['isUserGesture'])
       this._lastSelectedTabSetting.set(tabId);
-    var view = this._views.get(tabId);
-    if (!view)
-      return;
-
-    if (view.isCloseable()) {

[einbinder, 2017/05/23 00:12:25]

Tabs were persisted when they were selected, but it makes more sense for them to
be persisted when they are opened.

-      var tabs = this._closeableTabSetting.get();
-      if (!tabs[tabId]) {
-        tabs[tabId] = true;
-        this._closeableTabSetting.set(tabs);
-      }
-    }
   }
 
   /**
    * @param {!Common.Event} event
    */
   _tabClosed(event) {
     var id = /** @type {string} */ (event.data['tabId']);
     var tabs = this._closeableTabSetting.get();
     if (tabs[id]) {
       delete tabs[id];
       this._closeableTabSetting.set(tabs);
     }
   }
 
-  /**
-   * @param {!Common.Event} event
-   */
-  _persistTabOrder(event) {
+  _persistTabOrder() {
     var tabIds = this._tabbedPane.tabIds();
     var tabOrders = {};
     for (var i = 0; i < tabIds.length; i++)
       tabOrders[tabIds[i]] = (i + 1) * UI.ViewManager._TabbedLocation.orderStep;
     this._tabOrderSetting.set(tabOrders);
   }
 };
 
 UI.ViewManager._TabbedLocation.orderStep = 10;  // Keep in sync with descriptors.
 
@@ skipping 74 matching lines @@
   appendApplicableItems(locationName) {
     for (var view of this._manager._viewsForLocation(locationName))
       this.appendView(view);
   }
 };
 
 /**
  * @type {!UI.ViewManager}
  */
 UI.viewManager;