DevTools: Let the drawer tabs be reordered

third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 786 matching lines @@
    */
   elementsToRestoreScrollPositionsFor() {
     return [this._contentElement];
   }
 
   /**
    * @param {!UI.TabbedPaneTab} tab
    * @param {number} index
    */
   _insertBefore(tab, index) {
-    this._tabsElement.insertBefore(tab._tabElement || null, this._tabsElement.childNodes[index]);
+    this._tabsElement.insertBefore(tab.tabElement, this._tabsElement.childNodes[index]);

[einbinder, 2017/05/23 00:12:25]

_tabElement could be null, but insertBefore actually throws an error if the
first parameter is null.

     var oldIndex = this._tabs.indexOf(tab);
     this._tabs.splice(oldIndex, 1);
     if (oldIndex < index)
       --index;
     this._tabs.splice(index, 0, tab);
     this.dispatchEventToListeners(UI.TabbedPane.Events.TabOrderChanged, this._tabs);
   }
 
   /**
    * @return {!UI.Toolbar}
@@ skipping 209 matching lines @@
   /**
    * @param {boolean} measuring
    * @return {!Element}
    */
   _createTabElement(measuring) {
     var tabElement = createElementWithClass('div', 'tabbed-pane-header-tab');
     tabElement.id = 'tab-' + this._id;
     tabElement.tabIndex = -1;
     UI.ARIAUtils.markAsTab(tabElement);
     UI.ARIAUtils.setSelected(tabElement, false);
-    tabElement.selectTabForTest = this._tabbedPane.selectTab.bind(this._tabbedPane, this.id, true);

[einbinder, 2017/05/23 00:12:25]

This was unused.

 
     var titleElement = tabElement.createChild('span', 'tabbed-pane-header-tab-title');
     titleElement.textContent = this.title;
     titleElement.title = this.tooltip || '';
     this._createIconElement(tabElement, titleElement, measuring);
     if (!measuring)
       this._titleElement = titleElement;
 
     if (this._closeable)
       tabElement.createChild('div', 'tabbed-pane-close-button', 'dt-close-button').gray = true;
@@ skipping 177 matching lines @@
    * @param {!Array.<string>} ids
    */
   closeTabs(tabbedPane, ids) {},
 
   /**
    * @param {string} tabId
    * @param {!UI.ContextMenu} contextMenu
    */
   onContextMenu(tabId, contextMenu) {}
 };