Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java

Issue 2867103006: [Offline pages] Rename REMOVED to USER_CANCELED and add better foot note descriptions for histogram… (Closed)
Patch Set: Fix javatest reference to REMOVED, and old typo on retriable. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
index 0a9240f53024700f882453e9e680854a3d2d604c..5a098f64928ebe0220fdddd7d6890156b71e0864 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
@@ -33,7 +33,6 @@ import java.io.FileWriter;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStreamWriter;
-
import java.util.ArrayList;
import java.util.List;
import java.util.Properties;
@@ -392,8 +391,8 @@ public class OfflinePageSavePageLaterEvaluationTest
return "RETRY_COUNT_EXCEEDED";
case BackgroundSavePageResult.START_COUNT_EXCEEDED:
return "START_COUNT_EXCEEDED";
- case BackgroundSavePageResult.REMOVED:
- return "REMOVED";
+ case BackgroundSavePageResult.USER_CANCELED:
+ return "USER_CANCELED";
case -1:
return "NOT_COMPLETED";
default:
« no previous file with comments | « no previous file | components/offline_pages/core/background/request_coordinator.cc » ('j') | tools/metrics/histograms/enums.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698