third_party/WebKit/LayoutTests/accessibility/name-calc-aria-label.html - Issue 2867073003: Name calculation should not include nameFrom:author descendants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/accessibility/name-calc-aria-label.html

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/listitem-presentation-inherited-expected.txt ('k') | third_party/WebKit/LayoutTests/accessibility/name-calc-aria-labelledby.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/accessibility/name-calc-aria-label.html

diff --git a/third_party/WebKit/LayoutTests/accessibility/name-calc-aria-label.html b/third_party/WebKit/LayoutTests/accessibility/name-calc-aria-label.html

index 1831e2a4335cd9d23b7042a83b86ff13df6e244a..3e0104abb6dc13d2f47c7dcd3d3d4b7977a22d43 100644

--- a/third_party/WebKit/LayoutTests/accessibility/name-calc-aria-label.html

+++ b/third_party/WebKit/LayoutTests/accessibility/name-calc-aria-label.html

@@ -55,7 +55,7 @@ test(function(t) {

assert_equals(axLabelledby1.name, "Labelledby 1");

assert_equals(axLabelledby1.nameFrom, "relatedElement");

assert_equals(axLabelledby1.nameElementCount(), 1);

- assert_equals(axLabelledby1.nameElementAtIndex(0).role, "AXRole: AXDiv");

+ assert_equals(axLabelledby1.nameElementAtIndex(0).role, "AXRole: AXGenericContainer");

}, "aria-labelledby trumps both aria-label and contents.");

</script>

@@ -70,7 +70,7 @@ test(function(t) {

assert_equals(axLabelledby2.name, "Label 2 label");

assert_equals(axLabelledby2.nameFrom, "relatedElement");

assert_equals(axLabelledby2.nameElementCount(), 1);

- assert_equals(axLabelledby2.nameElementAtIndex(0).role, "AXRole: AXDiv");

+ assert_equals(axLabelledby2.nameElementAtIndex(0).role, "AXRole: AXGenericContainer");

}, "Button with aria-labelledby referencing an element with an aria-label uses the aria-label as text alternative.");

</script>

@@ -85,7 +85,7 @@ test(function(t) {

assert_equals(axLabelledby3.name, "Contents 3");

assert_equals(axLabelledby3.nameFrom, "relatedElement");

assert_equals(axLabelledby3.nameElementCount(), 1);

- assert_equals(axLabelledby3.nameElementAtIndex(0).role, "AXRole: AXDiv");

+ assert_equals(axLabelledby3.nameElementAtIndex(0).role, "AXRole: AXGenericContainer");

}, "aria-labelledby reference to element with empty aria-label.");

</script>

@@ -101,7 +101,7 @@ test(function(t) {

assert_equals(axLabelledby4.name, "Label 4 label");

assert_equals(axLabelledby4.nameFrom, "relatedElement");

assert_equals(axLabelledby4.nameElementCount(), 1);

- assert_equals(axLabelledby4.nameElementAtIndex(0).role, "AXRole: AXDiv");

+ assert_equals(axLabelledby4.nameElementAtIndex(0).role, "AXRole: AXGenericContainer");

}, "Recursive aria-labelledby references aren't followed even in presence of aria-label, even though aria-labelledby normally trumps aria-label.");

</script>