content/browser/accessibility/site_per_process_accessibility_browsertest.cc - Issue 2867073003: Name calculation should not include nameFrom:author descendants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/site_per_process_accessibility_browsertest.cc

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/hit_testing_browsertest.cc ('k') | content/browser/accessibility/snapshot_ax_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/site_per_process_accessibility_browsertest.cc

diff --git a/content/browser/accessibility/site_per_process_accessibility_browsertest.cc b/content/browser/accessibility/site_per_process_accessibility_browsertest.cc

index b5bc3a9a429e2879d7d92abb3fde47a4ec19c400..0249862607c0628db2d440217f43161010c95e1a 100644

--- a/content/browser/accessibility/site_per_process_accessibility_browsertest.cc

+++ b/content/browser/accessibility/site_per_process_accessibility_browsertest.cc

@@ -108,7 +108,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_SitePerProcessAccessibilityBrowserTest,

ASSERT_EQ(1U, ax_root->PlatformChildCount());

BrowserAccessibility* ax_group = ax_root->PlatformGetChild(0);

- EXPECT_EQ(ui::AX_ROLE_GROUP, ax_group->GetRole());

+ EXPECT_EQ(ui::AX_ROLE_GENERIC_CONTAINER, ax_group->GetRole());

ASSERT_EQ(2U, ax_group->PlatformChildCount());

BrowserAccessibility* ax_iframe = ax_group->PlatformGetChild(0);

@@ -123,7 +123,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_SitePerProcessAccessibilityBrowserTest,

BrowserAccessibility* ax_child_frame_group =

ax_child_frame_root->PlatformGetChild(0);

- EXPECT_EQ(ui::AX_ROLE_GROUP, ax_child_frame_group->GetRole());

+ EXPECT_EQ(ui::AX_ROLE_GENERIC_CONTAINER, ax_child_frame_group->GetRole());

ASSERT_EQ(1U, ax_child_frame_group->PlatformChildCount());

BrowserAccessibility* ax_child_frame_static_text =