content/browser/accessibility/browser_accessibility_manager_unittest.cc - Issue 2867073003: Name calculation should not include nameFrom:author descendants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_unittest.cc

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_com_win.cc ('k') | content/browser/accessibility/browser_accessibility_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_unittest.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_unittest.cc b/content/browser/accessibility/browser_accessibility_manager_unittest.cc

index bbb930e7223d4606f4f062b0f38606b7e93d4567..9766abfefe61cd0074b2e427055ce92383de4db2 100644

--- a/content/browser/accessibility/browser_accessibility_manager_unittest.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_unittest.cc

@@ -902,7 +902,7 @@ TEST(BrowserAccessibilityManagerTest, BoundsForRangeOnParentElement) {

ui::AXNodeData div;

div.id = 2;

- div.role = ui::AX_ROLE_DIV;

+ div.role = ui::AX_ROLE_GENERIC_CONTAINER;

div.location = gfx::RectF(100, 100, 100, 20);

div.child_ids.push_back(3);

div.child_ids.push_back(4);

@@ -1177,7 +1177,7 @@ TEST(BrowserAccessibilityManagerTest, TestFindIndicesInCommonParent) {

ui::AXNodeData div;

div.id = 2;

- div.role = ui::AX_ROLE_DIV;

+ div.role = ui::AX_ROLE_GENERIC_CONTAINER;

root.child_ids.push_back(div.id);

ui::AXNodeData button;

@@ -1320,7 +1320,7 @@ TEST(BrowserAccessibilityManagerTest, TestGetTextForRange) {

ui::AXNodeData div;

div.id = 2;

- div.role = ui::AX_ROLE_DIV;

+ div.role = ui::AX_ROLE_GENERIC_CONTAINER;

root.child_ids.push_back(div.id);

ui::AXNodeData button;