Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h b/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
index 789a85ce4b4eded5220e020bbcd891507b959316..8cd5e4d25d3bfe40812680c6d40ec77320e4bfce 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
@@ -59,8 +59,8 @@ enum class AOMStringProperty;
typedef unsigned AXID;
enum AccessibilityRole {
- kUnknownRole = 0,
- kAbbrRole, // No mapping to ARIA role.
+ kUnknownRole = 0, // Not mapped in platform APIs, generally indicates a bug
+ kAbbrRole, // No mapping to ARIA role.
kAlertDialogRole,
kAlertRole,
kAnchorRole, // No mapping to ARIA role.
@@ -92,7 +92,6 @@ enum AccessibilityRole {
kDialogRole,
kDirectoryRole,
kDisclosureTriangleRole, // No mapping to ARIA role.
- kDivRole, // No mapping to ARIA role.
kDocumentRole,
kEmbeddedObjectRole, // No mapping to ARIA role.
kFeedRole,
@@ -100,6 +99,7 @@ enum AccessibilityRole {
kFigureRole,
kFooterRole,
kFormRole,
+ kGenericContainerRole, // No role was defined for this container
kGridRole,
kGroupRole,
kHeadingRole,
@@ -135,7 +135,7 @@ enum AccessibilityRole {
kMenuRole,
kMeterRole,
kNavigationRole,
- kNoneRole, // No mapping to ARIA role.
+ kNoneRole, // ARIA role of "none"
kNoteRole,
kOutlineRole, // No mapping to ARIA role.
kParagraphRole, // No mapping to ARIA role.
@@ -1097,7 +1097,8 @@ class MODULES_EXPORT AXObjectImpl
return 0;
}
- virtual bool NameFromContents() const;
+ bool CanReceiveAccessibilityFocus() const;
+ bool NameFromContents(bool recursive) const;
AccessibilityRole ButtonRoleType() const;

Powered by Google App Engine
This is Rietveld 408576698