chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js - Issue 2867073003: Name calculation should not include nameFrom:author descendants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs » ('j') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

index 982a3ea45b3a990f9a353cae1a7c04e8b49a348c..81ad9c0eab1611a4fa2f2bd1f2e82430a04e68c2 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

@@ -449,7 +449,7 @@ Output.RULES = {

dialog: {

enter: '$nameFromNode $role $description'

- div: {

+ genericContainer: {

enter: '$nameFromNode',

speak: '$nameOrTextContent $description'

@@ -501,7 +501,8 @@ Output.RULES = {

'$description $state'

listItem: {

- enter: '$role'

+ enter: '$name= $role $state $description',

+ speak: '$nameOrDescendants $role $state $description'

menu: {

enter: '$name $role',