third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp - Issue 2867073003: Name calculation should not include nameFrom:author descendants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)

Patch Set: Single quote Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp b/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp

index 08c33dcda028eb1d96184be18e8818b2556ca392..f16eb77e77e3171745ffcfc00eb06a7f1369b588 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp

@@ -66,7 +66,7 @@ AXObjectImpl* AXSVGRoot::ComputeParent() const {

AccessibilityRole AXSVGRoot::DetermineAccessibilityRole() {

AccessibilityRole role = AXLayoutObject::DetermineAccessibilityRole();

if (role == kUnknownRole)

- role = kGroupRole;

+ role = kGenericContainerRole;

dmazzoni 2017/05/16 16:25:39 Maybe this one should be group?

aleventhal1 2017/05/16 18:11:26 Here's my general rule: role="group" or "fieldset"

dmazzoni 2017/05/17 22:07:39 Yeah, but the spec specifically says the default r

return role;

}