Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)
Patch Set: Single quote Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
index 2a1e5801392ea8b05805bb75c9747cfabd49bc50..ded93f71be52252bacd806e3df9906b2dba134ff 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
@@ -295,14 +295,15 @@ AccessibilityRole AXLayoutObject::DetermineAccessibilityRole() {
if (role != kUnknownRole)
return role;
+ // These are layout containers added by blink
if (layout_object_->IsLayoutBlockFlow())
- return kGroupRole;
+ return kGenericContainerRole;
// If the element does not have role, but it has ARIA attributes or is an
// in-page link target, accessibility should fallback to exposing it as a
// group.
dmazzoni 2017/05/16 16:25:38 update this comment
if (IsInPageLinkTarget() || SupportsARIAAttributes())
- return kGroupRole;
+ return kGenericContainerRole;
return kUnknownRole;
}

Powered by Google App Engine
This is Rietveld 408576698