third_party/WebKit/LayoutTests/accessibility/name-calc-aria-labelledby.html - Issue 2867073003: Name calculation should not include nameFrom:author descendants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/accessibility/name-calc-aria-labelledby.html

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)

Patch Set: Single quote Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/name-calc-aria-label.html ('k') | third_party/WebKit/LayoutTests/accessibility/name-calc-group-inside-treeitem.html » ('j') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/accessibility/name-calc-aria-labelledby.html

diff --git a/third_party/WebKit/LayoutTests/accessibility/name-calc-aria-labelledby.html b/third_party/WebKit/LayoutTests/accessibility/name-calc-aria-labelledby.html

index 7be5796d37d6ff6e53af035280d1e4075dffbbfe..14db8a9bbcdcc35dd3171490261e9e1f3d58ac54 100644

--- a/third_party/WebKit/LayoutTests/accessibility/name-calc-aria-labelledby.html

+++ b/third_party/WebKit/LayoutTests/accessibility/name-calc-aria-labelledby.html

@@ -42,7 +42,7 @@ test(function(t){

assert_equals(axLabelledby.name, "Label 1");

assert_equals(axLabelledby.nameFrom, "relatedElement");

assert_equals(axLabelledby.nameElementCount(), 1);

- assert_equals(axLabelledby.nameElementAtIndex(0).role, "AXRole: AXDiv");

+ assert_equals(axLabelledby.nameElementAtIndex(0).role, "AXRole: AXGenericContainer");

}, "Button with aria-labelledby referencing the id of another element.");

</script>

@@ -72,7 +72,7 @@ test(function(t){

assert_equals(axLabelledby3.nameFrom, "relatedElement");

assert_equals(axLabelledby3.nameElementCount(), 2);

assert_equals(axLabelledby3.nameElementAtIndex(0).role, "AXRole: AXButton");

- assert_equals(axLabelledby3.nameElementAtIndex(1).role, "AXRole: AXDiv");

+ assert_equals(axLabelledby3.nameElementAtIndex(1).role, "AXRole: AXGenericContainer");

}, "Button with aria-labelledby referencing itself and the id of another element.");

</script>

@@ -88,7 +88,7 @@ test(function(t){

assert_equals(axLabelledby4.name, "Contents 4");

assert_equals(axLabelledby4.nameFrom, "relatedElement");

assert_equals(axLabelledby4.nameElementCount(), 1);

- assert_equals(axLabelledby4.nameElementAtIndex(0).role, "AXRole: AXDiv");

+ assert_equals(axLabelledby4.nameElementAtIndex(0).role, "AXRole: AXGenericContainer");

}, "Button with chain of aria-labelledby references.");

</script>

@@ -116,7 +116,7 @@ test(function(t){

assert_equals(axLabelledby6.name, "");

assert_equals(axLabelledby6.nameFrom, "relatedElement");

assert_equals(axLabelledby6.nameElementCount(), 1);

- assert_equals(axLabelledby6.nameElementAtIndex(0).role, "AXRole: AXDiv");

+ assert_equals(axLabelledby6.nameElementAtIndex(0).role, "AXRole: AXGenericContainer");

}, "aria-labelledby reference to element with no text.");

</script>