content/browser/accessibility/browser_accessibility_android.cc - Issue 2867073003: Name calculation should not include nameFrom:author descendants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)

Patch Set: Single quote Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index 53ea353fb0578f3169e55e9fa3eca88603dace16..484ce491a2a9030ea9cb4fef3ad635e3ce0e3004 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -550,9 +550,6 @@ base::string16 BrowserAccessibilityAndroid::GetRoleDescription() const {

case ui::AX_ROLE_DISCLOSURE_TRIANGLE:

message_id = IDS_AX_ROLE_DISCLOSURE_TRIANGLE;

break;

- case ui::AX_ROLE_DIV:

- // No role description.

- break;

case ui::AX_ROLE_DOCUMENT:

message_id = IDS_AX_ROLE_DOCUMENT;

break;

@@ -574,6 +571,9 @@ base::string16 BrowserAccessibilityAndroid::GetRoleDescription() const {

case ui::AX_ROLE_FORM:

// No role description.

break;

+ case ui::AX_ROLE_GENERIC_CONTAINER:

+ // No role description.

+ break;

case ui::AX_ROLE_GRID:

message_id = IDS_AX_ROLE_TABLE;

break;