third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp - Issue 2867073003: Name calculation should not include nameFrom:author descendants.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs ('K') | « third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp ('k') | third_party/WebKit/Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Apple Inc. All rights reserved.	2 * Copyright (C) 2012 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 if (parent_)	59 if (parent_)

60 return parent_;	60 return parent_;

61	61

62 return AXLayoutObject::ComputeParent();	62 return AXLayoutObject::ComputeParent();

63 }	63 }

64	64

65 // SVG AAM 1.0 S8.2: the default role for an SVG root is "group".	65 // SVG AAM 1.0 S8.2: the default role for an SVG root is "group".

66 AccessibilityRole AXSVGRoot::DetermineAccessibilityRole() {	66 AccessibilityRole AXSVGRoot::DetermineAccessibilityRole() {

67 AccessibilityRole role = AXLayoutObject::DetermineAccessibilityRole();	67 AccessibilityRole role = AXLayoutObject::DetermineAccessibilityRole();

68 if (role == kUnknownRole)	68 if (role == kUnknownRole)

69 role = kGroupRole;	69 role = kGenericContainerRole;

70 return role;	70 return role;

71 }	71 }

72	72

73 // SVG elements are only ignored when a generic element would also be ignored.	73 // SVG elements are only ignored when a generic element would also be ignored.

74 bool AXSVGRoot::ComputeAccessibilityIsIgnored(IgnoredReasons* reasons) const {	74 bool AXSVGRoot::ComputeAccessibilityIsIgnored(IgnoredReasons* reasons) const {

75 return AccessibilityIsIgnoredByDefault(reasons);	75 return AccessibilityIsIgnoredByDefault(reasons);

76 }	76 }

77	77

78 } // namespace blink	78 } // namespace blink

OLD	NEW