Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)
Patch Set: Single quote Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 AXObjectImpl* AXSVGRoot::ComputeParent() const { 55 AXObjectImpl* AXSVGRoot::ComputeParent() const {
56 DCHECK(!IsDetached()); 56 DCHECK(!IsDetached());
57 // If a parent was set because this is a remote SVG resource, use that 57 // If a parent was set because this is a remote SVG resource, use that
58 // but otherwise, we should rely on the standard layout tree for the parent. 58 // but otherwise, we should rely on the standard layout tree for the parent.
59 if (parent_) 59 if (parent_)
60 return parent_; 60 return parent_;
61 61
62 return AXLayoutObject::ComputeParent(); 62 return AXLayoutObject::ComputeParent();
63 } 63 }
64 64
65 // SVG AAM 1.0 S8.2: the default role for an SVG root is "group". 65 // SVG AAM 1.0 S8.2: the default role for an SVG root is "group".
dmazzoni 2017/05/16 16:25:39 what about this comment?
66 AccessibilityRole AXSVGRoot::DetermineAccessibilityRole() { 66 AccessibilityRole AXSVGRoot::DetermineAccessibilityRole() {
67 AccessibilityRole role = AXLayoutObject::DetermineAccessibilityRole(); 67 AccessibilityRole role = AXLayoutObject::DetermineAccessibilityRole();
68 if (role == kUnknownRole) 68 if (role == kUnknownRole)
69 role = kGroupRole; 69 role = kGenericContainerRole;
dmazzoni 2017/05/16 16:25:39 Maybe this one should be group?
aleventhal1 2017/05/16 18:11:26 Here's my general rule: role="group" or "fieldset"
dmazzoni 2017/05/17 22:07:39 Yeah, but the spec specifically says the default r
70 return role; 70 return role;
71 } 71 }
72 72
73 // SVG elements are only ignored when a generic element would also be ignored. 73 // SVG elements are only ignored when a generic element would also be ignored.
74 bool AXSVGRoot::ComputeAccessibilityIsIgnored(IgnoredReasons* reasons) const { 74 bool AXSVGRoot::ComputeAccessibilityIsIgnored(IgnoredReasons* reasons) const {
75 return AccessibilityIsIgnoredByDefault(reasons); 75 return AccessibilityIsIgnoredByDefault(reasons);
76 } 76 }
77 77
78 } // namespace blink 78 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698