Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXMenuList.h

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)
Patch Set: Single quote Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 25 matching lines...) Expand all
36 class AXMenuList final : public AXLayoutObject { 36 class AXMenuList final : public AXLayoutObject {
37 WTF_MAKE_NONCOPYABLE(AXMenuList); 37 WTF_MAKE_NONCOPYABLE(AXMenuList);
38 38
39 public: 39 public:
40 static AXMenuList* Create(LayoutMenuList* layout_object, AXObjectCacheImpl&); 40 static AXMenuList* Create(LayoutMenuList* layout_object, AXObjectCacheImpl&);
41 41
42 bool IsCollapsed() const override; 42 bool IsCollapsed() const override;
43 AccessibilityExpanded IsExpanded() const final; 43 AccessibilityExpanded IsExpanded() const final;
44 bool Press() override; 44 bool Press() override;
45 void ClearChildren() override; 45 void ClearChildren() override;
46 bool NameFromContents() const override; 46 bool NameFromContents(const bool recursive) const override;
dmazzoni 2017/05/16 16:25:39 I think const bool is redundant, I don't normally
aleventhal1 2017/05/16 18:11:26 Done.
47 47
48 void DidUpdateActiveOption(int option_index); 48 void DidUpdateActiveOption(int option_index);
49 void DidShowPopup(); 49 void DidShowPopup();
50 void DidHidePopup(); 50 void DidHidePopup();
51 51
52 private: 52 private:
53 AXMenuList(LayoutMenuList*, AXObjectCacheImpl&); 53 AXMenuList(LayoutMenuList*, AXObjectCacheImpl&);
54 54
55 bool IsMenuList() const override { return true; } 55 bool IsMenuList() const override { return true; }
56 AccessibilityRole DetermineAccessibilityRole() final; 56 AccessibilityRole DetermineAccessibilityRole() final;
57 bool CanSetFocusAttribute() const override; 57 bool CanSetFocusAttribute() const override;
58 58
59 void AddChildren() override; 59 void AddChildren() override;
60 }; 60 };
61 61
62 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuList, IsMenuList()); 62 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuList, IsMenuList());
63 63
64 } // namespace blink 64 } // namespace blink
65 65
66 #endif // AXMenuList_h 66 #endif // AXMenuList_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698