Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp

Issue 2867073003: Name calculation should not include nameFrom:author descendants. (Closed)
Patch Set: Single quote Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 return; 65 return;
66 66
67 // There's no reason to clear our AXMenuListPopup child. If we get a 67 // There's no reason to clear our AXMenuListPopup child. If we get a
68 // call to clearChildren, it's because the options might have changed, 68 // call to clearChildren, it's because the options might have changed,
69 // so call it on our popup. 69 // so call it on our popup.
70 DCHECK(children_.size() == 1); 70 DCHECK(children_.size() == 1);
71 children_[0]->ClearChildren(); 71 children_[0]->ClearChildren();
72 children_dirty_ = false; 72 children_dirty_ = false;
73 } 73 }
74 74
75 bool AXMenuList::NameFromContents() const { 75 bool AXMenuList::NameFromContents(const bool recursive) const {
76 return false; 76 return false;
77 } 77 }
78 78
79 void AXMenuList::AddChildren() { 79 void AXMenuList::AddChildren() {
80 DCHECK(!IsDetached()); 80 DCHECK(!IsDetached());
81 have_children_ = true; 81 have_children_ = true;
82 82
83 AXObjectCacheImpl& cache = AxObjectCache(); 83 AXObjectCacheImpl& cache = AxObjectCache();
84 84
85 AXObjectImpl* list = cache.GetOrCreate(kMenuListPopupRole); 85 AXObjectImpl* list = cache.GetOrCreate(kMenuListPopupRole);
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 150
151 AXMenuListPopup* popup = ToAXMenuListPopup(Children()[0].Get()); 151 AXMenuListPopup* popup = ToAXMenuListPopup(Children()[0].Get());
152 popup->DidHide(); 152 popup->DidHide();
153 153
154 if (GetNode() && GetNode()->IsFocused()) 154 if (GetNode() && GetNode()->IsFocused())
155 AxObjectCache().PostNotification( 155 AxObjectCache().PostNotification(
156 this, AXObjectCacheImpl::kAXFocusedUIElementChanged); 156 this, AXObjectCacheImpl::kAXFocusedUIElementChanged);
157 } 157 }
158 158
159 } // namespace blink 159 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698