Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: components/crash/content/app/crashpad_win.cc

Issue 2867063002: Stability instrumentation Crashpad integration (Closed)
Patch Set: Siggi round 3 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/crashpad_win.cc
diff --git a/components/crash/content/app/crashpad_win.cc b/components/crash/content/app/crashpad_win.cc
index 94a350f4b5a45481dd0fd88bf695ebc225301948..6fdfd83d163dea5e8083bb9c14c5c8902f8ce4c9 100644
--- a/components/crash/content/app/crashpad_win.cc
+++ b/components/crash/content/app/crashpad_win.cc
@@ -52,9 +52,11 @@ void GetPlatformCrashpadAnnotations(
#endif
}
-base::FilePath PlatformCrashpadInitialization(bool initial_client,
- bool browser_process,
- bool embedded_handler) {
+base::FilePath PlatformCrashpadInitialization(
+ bool initial_client,
+ bool browser_process,
+ bool embedded_handler,
+ const std::string& user_data_dir) {
base::FilePath database_path; // Only valid in the browser process.
base::FilePath metrics_path; // Only valid in the browser process.
@@ -107,6 +109,10 @@ base::FilePath PlatformCrashpadInitialization(bool initial_client,
if (embedded_handler) {
start_arguments.push_back(std::string("--type=") +
switches::kCrashpadHandler);
+ if (!user_data_dir.empty()) {
+ start_arguments.push_back(std::string("--user-data-dir=") +
grt (UTC plus 2) 2017/05/11 21:08:16 "user-data-dir" is a chromium-ish thing, whereas c
manzagop (departed) 2017/05/12 19:27:32 The crash handler on Windows is embedded inside ch
grt (UTC plus 2) 2017/05/15 13:03:18 Ah, okay, so this is used only in Chromium's crash
manzagop (departed) 2017/05/15 13:43:45 That is correct.
+ user_data_dir);
+ }
// The prefetch argument added here has to be documented in
// chrome_switches.cc, below the kPrefetchArgument* constants. A constant
// can't be used here because crashpad can't depend on Chrome.

Powered by Google App Engine
This is Rietveld 408576698