Index: chrome/app/chrome_crash_reporter_client_win.cc |
diff --git a/chrome/app/chrome_crash_reporter_client_win.cc b/chrome/app/chrome_crash_reporter_client_win.cc |
index 166a13df213ba18e27c5b895c40dd31f932cb6e6..9feae96bfbed6e58a9dce6f8ccd189b66b57fb3a 100644 |
--- a/chrome/app/chrome_crash_reporter_client_win.cc |
+++ b/chrome/app/chrome_crash_reporter_client_win.cc |
@@ -14,6 +14,7 @@ |
#include <iterator> |
#include <memory> |
#include <string> |
+#include <vector> |
#include "base/command_line.h" |
#include "base/debug/crash_logging.h" |
@@ -240,13 +241,17 @@ void ChromeCrashReporterClient::InitializeCrashReportingForProcess() { |
std::wstring process_type = install_static::GetSwitchValueFromCommandLine( |
::GetCommandLine(), install_static::kProcessType); |
+ std::wstring user_data_dir; |
+ // DO NOT SUBMIT: validate use of CHECK. |
+ CHECK(install_static::GetUserDataDirectory(&user_data_dir, nullptr)); |
grt (UTC plus 2)
2017/05/11 21:08:16
i think this is wrong. the one true user data dir
manzagop (departed)
2017/05/12 19:27:32
I tried the second approach.
- I needed to make t
grt (UTC plus 2)
2017/05/15 13:03:18
Ah, I see now that the user data dir is only compu
manzagop (departed)
2017/05/15 13:43:45
Why do you say the user-data-dir would be not init
manzagop (departed)
2017/05/15 14:21:35
As per offline discussion, the concern is wasted w
|
// Don't set up Crashpad crash reporting in the Crashpad handler itself, nor |
// in the fallback crash handler for the Crashpad handler process. |
if (process_type != install_static::kCrashpadHandler && |
process_type != install_static::kFallbackHandler) { |
crash_reporter::SetCrashReporterClient(instance); |
crash_reporter::InitializeCrashpadWithEmbeddedHandler( |
- process_type.empty(), install_static::UTF16ToUTF8(process_type)); |
+ process_type.empty(), install_static::UTF16ToUTF8(process_type), |
+ install_static::UTF16ToUTF8(user_data_dir)); |
} |
} |
#endif // NACL_WIN64 |