Stability instrumentation Crashpad integration

chrome/app/chrome_crash_reporter_client_win.cc

Index: chrome/app/chrome_crash_reporter_client_win.cc
diff --git a/chrome/app/chrome_crash_reporter_client_win.cc b/chrome/app/chrome_crash_reporter_client_win.cc
index 166a13df213ba18e27c5b895c40dd31f932cb6e6..9feae96bfbed6e58a9dce6f8ccd189b66b57fb3a 100644
--- a/chrome/app/chrome_crash_reporter_client_win.cc
+++ b/chrome/app/chrome_crash_reporter_client_win.cc
@@ -14,6 +14,7 @@
 #include <iterator>
 #include <memory>
 #include <string>
+#include <vector>

[Sigurður Ásgeirsson, 2017/05/11 15:33:40]

was missing?

[manzagop (departed), 2017/05/11 19:14:53]

Yup. Ack.

 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
@@ -240,13 +241,17 @@ void ChromeCrashReporterClient::InitializeCrashReportingForProcess() {
 
   std::wstring process_type = install_static::GetSwitchValueFromCommandLine(
       ::GetCommandLine(), install_static::kProcessType);
+  std::wstring user_data_dir;
+  // DO NOT SUBMIT: validate use of CHECK.

[Sigurður Ásgeirsson, 2017/05/11 15:33:40]

Ask grt. It feels wonky to CHECK before crash reporting has been set up, though.
If this fails in the field, there's no safety net that'd inform us.

[manzagop (departed), 2017/05/11 19:14:53]

Will do.

We actually have 2 calls to this function. This one in the crash client, and
another in the handler. In the handler, I've made a change to interpret an empty
value as missing, in which case we don't attempt to create an crumbs extension.

+  CHECK(install_static::GetUserDataDirectory(&user_data_dir, nullptr));
   // Don't set up Crashpad crash reporting in the Crashpad handler itself, nor
   // in the fallback crash handler for the Crashpad handler process.
   if (process_type != install_static::kCrashpadHandler &&
       process_type != install_static::kFallbackHandler) {
     crash_reporter::SetCrashReporterClient(instance);
     crash_reporter::InitializeCrashpadWithEmbeddedHandler(
-        process_type.empty(), install_static::UTF16ToUTF8(process_type));
+        process_type.empty(), install_static::UTF16ToUTF8(process_type),
+        install_static::UTF16ToUTF8(user_data_dir));
   }
 }
 #endif  // NACL_WIN64