Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1998)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2867063002: Stability instrumentation Crashpad integration (Closed)
Patch Set: Moar comments and fixups Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_crash_reporter_client_win.cc
diff --git a/chrome/app/chrome_crash_reporter_client_win.cc b/chrome/app/chrome_crash_reporter_client_win.cc
index a0343abb2c7e9454c36e1cd1872af0f112224482..26b455c7ce8f39f1a41c77a7cff554743f6ce0f3 100644
--- a/chrome/app/chrome_crash_reporter_client_win.cc
+++ b/chrome/app/chrome_crash_reporter_client_win.cc
@@ -14,6 +14,7 @@
#include <iterator>
#include <memory>
#include <string>
+#include <vector>
#include "base/command_line.h"
#include "base/debug/crash_logging.h"
@@ -257,13 +258,17 @@ void ChromeCrashReporterClient::InitializeCrashReportingForProcess() {
std::wstring process_type = install_static::GetSwitchValueFromCommandLine(
::GetCommandLine(), install_static::kProcessType);
+ std::wstring user_data_dir;
+ // DO NOT SUBMIT: validate use of CHECK.
+ CHECK(install_static::GetUserDataDirectory(&user_data_dir, nullptr));
// Don't set up Crashpad crash reporting in the Crashpad handler itself, nor
// in the fallback crash handler for the Crashpad handler process.
if (process_type != install_static::kCrashpadHandler &&
process_type != install_static::kFallbackHandler) {
crash_reporter::SetCrashReporterClient(instance);
crash_reporter::InitializeCrashpadWithEmbeddedHandler(
- process_type.empty(), install_static::UTF16ToUTF8(process_type));
+ process_type.empty(), install_static::UTF16ToUTF8(process_type),
+ install_static::UTF16ToUTF8(user_data_dir));
}
}
#endif // NACL_WIN64

Powered by Google App Engine
This is Rietveld 408576698