Stability instrumentation Crashpad integration

chrome/install_static/install_util.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains helper functions which provide information about the
 // current version of Chrome. This includes channel information, version
 // information etc. This functionality is provided by using functions in
 // kernel32 and advapi32. No other dependencies are allowed in this file.
 
 #ifndef CHROME_INSTALL_STATIC_INSTALL_UTIL_H_
@@ skipping 131 matching lines @@
 // Returns true if if usage stats reporting is controlled by a mandatory
 // policy. |crash_reporting_enabled| determines whether it's enabled (true) or
 // disabled (false).
 bool ReportingIsEnforcedByPolicy(bool* crash_reporting_enabled);
 
 // Initializes |g_process_type| which stores whether or not the current
 // process is the main browser process.
 void InitializeProcessType();
 
 // Returns true if the process type is initialized. False otherwise.
 bool IsProcessTypeInitialized();

[robertshield, 2017/05/24 18:10:48]

It's not clear to me that this needs to be in the public interface anymore.

[manzagop (departed), 2017/05/24 21:48:47]

Done.

 
 // Returns true if invoked in a Chrome process other than the main browser
 // process. False otherwise.
 bool IsNonBrowserProcess();
 
 // Returns true if the |process_type| has the rights to access the profile.
 // False otherwise.
 bool ProcessNeedsProfileDir(const std::string& process_type);
 
-// Populates |crash_dir| with the crash dump location, respecting modifications
-// to user-data-dir.
-// TODO(ananta)
-// http://crbug.com/604923
-// Unify this with the Browser Distribution code.
+// Returns true if the current process has the rights to access the profile.
+// False otherwise.
+bool CurrentProcessNeedsProfileDir();
+
+// Retrieves the user data directory, or an empty string on failure.
+std::wstring GetUserDataDirectory();
+
+// Retrieves an invalid user data directory specified by the user, or an empty
+// string.
+std::wstring GetInvalidUserDataDirectory();
+
+// Returns the crash dump location, respecting modifications to user-data-dir,
+// or the empty string on failure.
+// TODO(ananta): Unify this with the Browser Distribution code.
+//    http://crbug.com/604923
 std::wstring GetCrashDumpLocation();
 
 // Returns the contents of the specified |variable_name| from the environment
 // block of the calling process. Returns an empty string if the variable does
 // not exist.
 std::string GetEnvironmentString(const std::string& variable_name);
 std::wstring GetEnvironmentString16(const wchar_t* variable_name);
 
 // Sets the environment variable identified by |variable_name| to the value
 // identified by |new_value|.
@@ skipping 73 matching lines @@
 // key in the registry.
 std::wstring DetermineChannel(const InstallConstants& mode,
                               bool system_level,
                               bool from_binaries,
                               std::wstring* update_ap,
                               std::wstring* update_cohort_name);
 
 }  // namespace install_static
 
 #endif  // CHROME_INSTALL_STATIC_INSTALL_UTIL_H_