Stability instrumentation Crashpad integration

chrome/install_static/product_install_details.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/install_static/product_install_details.h"
 
 #include <windows.h>
 
 #include <algorithm>
 
 #include "chrome/install_static/install_details.h"
 #include "chrome/install_static/install_modes.h"
 #include "chrome/install_static/install_util.h"
+#include "chrome/install_static/user_data_dir.h"
 #include "chrome_elf/nt_registry/nt_registry.h"
 
 namespace install_static {
 
 namespace {
 
 // Returns the executable path for the current process.
 std::wstring GetCurrentProcessExePath() {
   std::wstring exe_path(MAX_PATH, L'\0');
   DWORD length = ::GetModuleFileName(nullptr, &exe_path[0], exe_path.size());
@@ skipping 108 matching lines @@
   // Cache the ap and cohort name values found in the registry for use in crash
   // keys and in about:version.
   std::wstring update_ap;
   std::wstring update_cohort_name;
   details->set_channel(DetermineChannel(*mode, system_level,
                                         false /* !from_binaries */, &update_ap,
                                         &update_cohort_name));
   details->set_update_ap(update_ap);
   details->set_update_cohort_name(update_cohort_name);
 
+  if (CurrentProcessNeedsProfileDir()) {
+    std::wstring user_data_dir;
+    std::wstring invalid_user_data_dir;
+    install_static::GetAndCacheUserDataDirectory(*mode, &user_data_dir,

[grt (UTC plus 2), 2017/05/22 10:16:12]

this function no longer needs to do caching. how about removing that and
renaming it?

[manzagop (departed), 2017/05/23 14:59:14]

Done.

+                                                 &invalid_user_data_dir);
+    details->set_user_data_dir(user_data_dir);
+    details->set_invalid_user_data_dir(invalid_user_data_dir);
+  }
+
   return details;
 }
 
 }  // namespace install_static