Stability instrumentation Crashpad integration

chrome_elf/chrome_elf_main.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_elf/chrome_elf_main.h"
 
 #include <assert.h>
 #include <windows.h>
 
 #include "chrome/install_static/install_details.h"
@@ skipping 11 matching lines @@
 #ifdef _DEBUG
     assert(false);
 #endif  // _DEBUG
   }
 }
 
 void SignalChromeElf() {
   blacklist::ResetBeacon();
 }
 
 extern "C" void GetUserDataDirectoryThunk(wchar_t* user_data_dir,

[grt (UTC plus 2), 2017/05/19 08:15:50]

this thunk isn't needed any more, is it? can its consumers now simply use the
value in InstallDetails?

[manzagop (departed), 2017/05/19 22:02:07]

Done.

                                           size_t user_data_dir_length,
                                           wchar_t* invalid_user_data_dir,
                                           size_t invalid_user_data_dir_length) {
   std::wstring user_data_dir_str, invalid_user_data_dir_str;
-  bool ret = install_static::GetUserDataDirectory(&user_data_dir_str,
-                                                  &invalid_user_data_dir_str);
+  bool ret = install_static::GetUserDataDirectory(
+      install_static::InstallDetails::Get().mode(), &user_data_dir_str,
+      &invalid_user_data_dir_str);
   assert(ret);
   install_static::IgnoreUnused(ret);
   wcsncpy_s(user_data_dir, user_data_dir_length, user_data_dir_str.c_str(),
             _TRUNCATE);
   wcsncpy_s(invalid_user_data_dir, invalid_user_data_dir_length,
             invalid_user_data_dir_str.c_str(), _TRUNCATE);
 }
 
 BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {
   if (reason == DLL_PROCESS_ATTACH) {
     install_static::InitializeProductDetailsForPrimaryModule();
 
     // CRT on initialization installs an exception filter which calls
     // TerminateProcess. We need to hook CRT's attempt to set an exception.
     elf_crash::DisableSetUnhandledExceptionFilter();
 
     install_static::InitializeProcessType();
 
     __try {
       blacklist::Initialize(false);  // Don't force, abort if beacon is present.
     } __except (elf_crash::GenerateCrashDump(GetExceptionInformation())) {
     }
   } else if (reason == DLL_PROCESS_DETACH) {
     elf_crash::ShutdownCrashReporting();
   }
   return TRUE;
 }