Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2867023002: [ServiceWorker] waitUntil() should wait until all promises got resolved/rejected. (Closed)
Patch Set: More clean up Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
index ee4bea65b9ccaa5c3b826e28fb46d8ef8aa67581..1b3ca7629a414997e8060ff4166493c5cd58d768 100644
--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
@@ -290,7 +290,7 @@ void ServiceWorkerGlobalScopeProxy::DispatchFetchEvent(
respond_with_observer->DidDispatchEvent(dispatch_result);
// false is okay because waitUntil for fetch event doesn't care about the
// promise rejection or an uncaught runtime script error.
- wait_until_observer->DidDispatchEvent(false /* errorOccurred */);
+ wait_until_observer->DidDispatchEvent(false /* event_dispatch_failed */);
}
void ServiceWorkerGlobalScopeProxy::OnNavigationPreloadResponse(
@@ -383,7 +383,7 @@ void ServiceWorkerGlobalScopeProxy::DispatchForeignFetchEvent(
respond_with_observer->DidDispatchEvent(dispatch_result);
// false is okay because waitUntil for foreign fetch event doesn't care
// about the promise rejection or an uncaught runtime script error.
- wait_until_observer->DidDispatchEvent(false /* errorOccurred */);
+ wait_until_observer->DidDispatchEvent(false /* event_dispatch_failed */);
}
void ServiceWorkerGlobalScopeProxy::DispatchInstallEvent(int event_id) {
@@ -477,7 +477,7 @@ void ServiceWorkerGlobalScopeProxy::DispatchPaymentRequestEvent(
respond_with_observer->DidDispatchEvent(dispatch_result);
// false is okay because waitUntil for payment request event doesn't care
// about the promise rejection or an uncaught runtime script error.
- wait_until_observer->DidDispatchEvent(false /* errorOccurred */);
+ wait_until_observer->DidDispatchEvent(false /* event_dispatch_failed */);
}
bool ServiceWorkerGlobalScopeProxy::HasFetchEventHandler() {
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698