third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h - Issue 2867023002: [ServiceWorker] waitUntil() should wait until all promises got resolved/rejected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h

Issue 2867023002: [ServiceWorker] waitUntil() should wait until all promises got resolved/rejected. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/extendable-event-waituntil.https-expected.txt ('k') | third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp » ('j') | third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h b/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h

index 072d09304e728c8fb0174fc78dca29a99637f02c..c43c21a437fe4cdd775868fe668465b56aea0ce5 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h

@@ -64,7 +64,7 @@ class MODULES_EXPORT WaitUntilObserver final

WaitUntilObserver(ExecutionContext*, EventType, int event_id);

- void ReportError(const ScriptValue&);

+ void ReportPromiseRejected(const ScriptValue&);

void ConsumeWindowInteraction(TimerBase*);

@@ -73,6 +73,7 @@ class MODULES_EXPORT WaitUntilObserver final

int event_id_;

int pending_activity_ = 0;

bool has_error_ = false;

+ bool has_rejected_promise_ = false;

bool event_dispatched_ = false;

double event_dispatch_time_ = 0;

TaskRunnerTimer<WaitUntilObserver> consume_window_interaction_timer_;