Issue 2866973005: align fasta.Token and analyzer.Token

Issue 2866973005: align fasta.Token and analyzer.Token (Closed)

Created:
3 years, 7 months ago by danrubel

Modified:
3 years, 6 months ago

Reviewers:
Paul Berry, scheglov, ahe

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

align fasta.Token and analyzer.Token * move kind to analyzer.Token * move charOffset, charLength, charEnd to analyzer.Token * move isEOF from fasta.Token into analyzer.Token * move stringValue into TokenType R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a14bda01a94c8553a72d08fd7d75a195d786cb83

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -56 lines)			Patch
M	pkg/front_end/lib/src/fasta/scanner/error_token.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/scanner/token.dart	View	7 chunks	+7 lines, -38 lines	0 comments	Download
M	pkg/front_end/lib/src/scanner/token.dart	View	10 chunks	+98 lines, -16 lines	0 comments	Download

Total messages: 8 (3 generated)

danrubel

Committed patchset #1 (id:1) manually as a14bda01a94c8553a72d08fd7d75a195d786cb83 (presubmit successful).

3 years, 7 months ago (2017-05-08 19:44:44 UTC) #6

Message was sent while issue was closed.

lgtm