Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 286693003: QUIC - cleanup changes per comments for CL's 279453004, 283693002 (Closed)

Created:
6 years, 7 months ago by ramant (doing other things)
Modified:
6 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Hamilton, Ian Swett, Robbie Shade
Visibility:
Public.

Description

QUIC - cleanup changes per comments for CL's 279453004, 283693002 + Fixed comments. + Used "for" loop instead of "while" loop. https://codereview.chromium.org/279453004/ https://codereview.chromium.org/283693002/ R=wtc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M net/quic/quic_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
6 years, 7 months ago (2014-05-14 05:27:32 UTC) #1
wtc
Patch set 1 LGTM. Thanks.
6 years, 7 months ago (2014-05-14 16:46:10 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 7 months ago (2014-05-14 18:54:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/286693003/1
6 years, 7 months ago (2014-05-14 18:55:55 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 21:28:04 UTC) #5
Message was sent while issue was closed.
Change committed as 270476

Powered by Google App Engine
This is Rietveld 408576698