Validate generated MHTML in mhtml_generation_browsertest.cc tests.

content/browser/download/mhtml_generation_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <memory>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "base/threading/thread_restrictions.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/common/frame_messages.h"
 #include "content/public/browser/mhtml_extra_parts.h"
+#include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/mhtml_generation_params.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "content/shell/browser/shell.h"
 #include "net/base/filename_util.h"
 #include "net/dns/mock_host_resolver.h"
@@ skipping 86 matching lines @@
     histogram_tester_.reset(new base::HistogramTester());
 
     shell()->web_contents()->GenerateMHTML(
         params, base::Bind(&MHTMLGenerationTest::MHTMLGenerated,
                            base::Unretained(this),
                            run_loop.QuitClosure()));
 
     // Block until the MHTML is generated.
     run_loop.Run();
 
-    EXPECT_TRUE(has_mhtml_callback_run());
+    ASSERT_TRUE(has_mhtml_callback_run())
+        << "An error occurred while generating the MHTML file";
+
+    // Loads the generated file to check if it is well formed.
+    WebContentsDelegate* old_delegate = shell()->web_contents()->GetDelegate();
+    ConsoleObserverDelegate console_delegate(shell()->web_contents(),
+                                             "Malformed multipart archive: *");
+    shell()->web_contents()->SetDelegate(&console_delegate);
+
+    NavigateToURL(shell(), net::FilePathToFileURL(params.file_path));

[nasko, 2017/05/08 17:16:58]

EXPECT_TRUE, otherwise failure to load, such as file not found, will not be
detected.

[carlosk, 2017/05/16 20:56:08]

Done.

+    EXPECT_EQ(0U, console_delegate.message().length())
+        << "The generated MHTML file is malformed";
+
+    shell()->web_contents()->SetDelegate(old_delegate);
   }
 
   int64_t ReadFileSizeFromDisk(base::FilePath path) {
     base::ThreadRestrictions::ScopedAllowIO allow_io_to_test_file_size;
     int64_t file_size;
     if (!base::GetFileSize(path, &file_size)) return -1;
     return file_size;
   }
 
   void TestOriginalVsSavedPage(
       const GURL& url,
       const MHTMLGenerationParams params,
       int expected_number_of_frames,
       const std::vector<std::string>& expected_substrings,
       const std::vector<std::string>& forbidden_substrings_in_saved_page,
       bool skip_verification_of_original_page = false) {
     // Navigate to the test page and verify if test expectations
     // are met (this is mostly a sanity check - a failure to meet
     // expectations would probably mean that there is a test bug
     // (i.e. that we got called with wrong expected_foo argument).
     NavigateToURL(shell(), url);
     if (!skip_verification_of_original_page) {
       AssertExpectationsAboutCurrentTab(expected_number_of_frames,
                                         expected_substrings,
                                         std::vector<std::string>());
     }
 
     GenerateMHTML(params, url);
-    ASSERT_FALSE(HasFailure());
 
     // Stop the test server (to make sure the locally saved page
     // is self-contained / won't try to open original resources).
     ASSERT_TRUE(embedded_test_server()->ShutdownAndWaitUntilComplete());
 
     // Open the saved page and verify if test expectations are
     // met (i.e. if the same expectations are met for "after"
     // [saved version of the page] as for the "before"
     // [the original version of the page].
     NavigateToURL(shell(), net::FilePathToFileURL(params.file_path));
@@ skipping 49 matching lines @@
 
 // Tests that generating a MHTML does create contents.
 // Note that the actual content of the file is not tested, the purpose of this
 // test is to ensure we were successful in creating the MHTML data from the
 // renderer.
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, GenerateMHTML) {
   base::FilePath path(temp_dir_.GetPath());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
 
   GenerateMHTML(path, embedded_test_server()->GetURL("/simple_page.html"));
-  ASSERT_FALSE(HasFailure());
 
   // Make sure the actual generated file has some contents.
   EXPECT_GT(file_size(), 0);  // Verify the size reported by the callback.
   EXPECT_GT(ReadFileSizeFromDisk(path), 100);  // Verify the actual file size.
 
   {
     base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
     std::string mhtml;
     ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
     EXPECT_THAT(mhtml,
@@ skipping 119 matching lines @@
   GenerateMHTMLForCurrentPage(MHTMLGenerationParams(path));
 
   EXPECT_GT(ReadFileSizeFromDisk(path), 100);  // Verify the actual file size.
 }
 
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, InvalidPath) {
   base::FilePath path(FILE_PATH_LITERAL("/invalid/file/path"));
 
   GenerateMHTML(path, embedded_test_server()->GetURL(
                           "/download/local-about-blank-subframes.html"));
-  ASSERT_FALSE(HasFailure());  // No failures with the invocation itself?
 
   EXPECT_EQ(file_size(), -1);  // Expecting that the callback reported failure.
 
   // Checks that the final status reported to UMA is correct.
   histogram_tester()->ExpectUniqueSample(
       "PageSerialization.MhtmlGeneration.FinalSaveStatus",
       static_cast<int>(MhtmlSaveStatus::FILE_CREATION_ERROR), 1);
 }
 
 // Tests that MHTML generated using the default 'quoted-printable' encoding does
 // not contain the 'binary' Content-Transfer-Encoding header, and generates
 // base64 encoding for the image part.
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, GenerateNonBinaryMHTMLWithImage) {
   base::FilePath path(temp_dir_.GetPath());
   path = path.Append(FILE_PATH_LITERAL("test_binary.mht"));
 
   GURL url(embedded_test_server()->GetURL("/page_with_image.html"));
   GenerateMHTML(path, url);
-  ASSERT_FALSE(HasFailure());
   EXPECT_GT(file_size(), 0);  // Verify the size reported by the callback.
   EXPECT_GT(ReadFileSizeFromDisk(path), 100);  // Verify the actual file size.
 
   {
     base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
     std::string mhtml;
     ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
     EXPECT_THAT(mhtml, HasSubstr("Content-Transfer-Encoding: base64"));
     EXPECT_THAT(mhtml, Not(HasSubstr("Content-Transfer-Encoding: binary")));
     EXPECT_THAT(mhtml, ContainsRegex("Content-Location:.*blank.jpg"));
   }
 }
 
 // Tests that MHTML generated using the binary encoding contains the 'binary'
 // Content-Transfer-Encoding header, and does not contain any base64 encoded
 // parts.
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, GenerateBinaryMHTMLWithImage) {
   base::FilePath path(temp_dir_.GetPath());
   path = path.Append(FILE_PATH_LITERAL("test_binary.mht"));
 
   GURL url(embedded_test_server()->GetURL("/page_with_image.html"));
   MHTMLGenerationParams params(path);
   params.use_binary_encoding = true;
 
   GenerateMHTML(params, url);
-  ASSERT_FALSE(HasFailure());
   EXPECT_GT(file_size(), 0);  // Verify the size reported by the callback.
   EXPECT_GT(ReadFileSizeFromDisk(path), 100);  // Verify the actual file size.
 
   {
     base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
     std::string mhtml;
     ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
     EXPECT_THAT(mhtml, HasSubstr("Content-Transfer-Encoding: binary"));
     EXPECT_THAT(mhtml, Not(HasSubstr("Content-Transfer-Encoding: base64")));
     EXPECT_THAT(mhtml, ContainsRegex("Content-Location:.*blank.jpg"));
   }
 }
 
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, GenerateMHTMLIgnoreNoStore) {
   base::FilePath path(temp_dir_.GetPath());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
 
   GURL url(embedded_test_server()->GetURL("/nostore.html"));
 
   // Generate MHTML without specifying the FailForNoStoreMainFrame policy.
   GenerateMHTML(path, url);
 
-  // We expect that there wasn't an error (file size -1 indicates an error.)
-  ASSERT_FALSE(HasFailure());
-
   std::string mhtml;
   {
     base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
     ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
   }
 
   // Make sure the contents of the body are present.
   EXPECT_THAT(mhtml, HasSubstr("test body"));
 
   // Make sure that URL of the content is present.
@@ skipping 176 matching lines @@
 };
 
 // Test for crbug.com/538766.
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationSitePerProcessTest, GenerateMHTML) {
   base::FilePath path(temp_dir_.GetPath());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
 
   GURL url(embedded_test_server()->GetURL(
       "a.com", "/frame_tree/page_with_one_frame.html"));
   GenerateMHTML(path, url);
-  ASSERT_FALSE(HasFailure());
 
   std::string mhtml;
   {
     base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
     ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
   }
 
   // Make sure the contents of both frames are present.
   EXPECT_THAT(mhtml, HasSubstr("This page has one cross-site iframe"));
   EXPECT_THAT(mhtml, HasSubstr("This page has no title"));  // From title1.html.
 
   // Make sure that URLs of both frames are present
   // (note that these are single-line regexes).
   EXPECT_THAT(
       mhtml,
       ContainsRegex("Content-Location:.*/frame_tree/page_with_one_frame.html"));
   EXPECT_THAT(mhtml, ContainsRegex("Content-Location:.*/title1.html"));
 }
 
 IN_PROC_BROWSER_TEST_F(MHTMLGenerationTest, RemovePopupOverlay) {
   base::FilePath path(temp_dir_.GetPath());
   path = path.Append(FILE_PATH_LITERAL("test.mht"));
 
   GURL url(embedded_test_server()->GetURL("/popup.html"));
 
   MHTMLGenerationParams params(path);
   params.remove_popup_overlay = true;
 
   GenerateMHTML(params, url);
-  ASSERT_FALSE(HasFailure());
 
   std::string mhtml;
   {
     base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
     ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
   }
 
   // Make sure the overlay is removed.
   EXPECT_THAT(mhtml, Not(HasSubstr("class=3D\"overlay")));
   EXPECT_THAT(mhtml, Not(HasSubstr("class=3D\"modal")));
@@ skipping 34 matching lines @@
     base::ThreadRestrictions::ScopedAllowIO allow_io_for_content_verification;
     ASSERT_TRUE(base::ReadFileToString(path, &mhtml));
   }
 
   // Make sure that both extra data parts made it into the mhtml.
   EXPECT_THAT(mhtml, HasSubstr(kFakeSignalData1));
   EXPECT_THAT(mhtml, HasSubstr(kFakeSignalData2));
 }
 
 }  // namespace content