Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: chrome/browser/android/vr_shell/vr_browser_interface.h

Issue 2866853002: VR: Wire VrShell UI-related state to the scene manager. (Closed)
Patch Set: Rebase; remove now-unused source file. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/vr_browser_interface.h
diff --git a/chrome/browser/android/vr_shell/vr_browser_interface.h b/chrome/browser/android/vr_shell/vr_browser_interface.h
index 170fe800e37fffbb20dc2cca997d436b6ee87077..d852cf9b079e2acf09902d151cf57a66f6fcf4a6 100644
--- a/chrome/browser/android/vr_shell/vr_browser_interface.h
+++ b/chrome/browser/android/vr_shell/vr_browser_interface.h
@@ -27,18 +27,18 @@ class VrBrowserInterface {
public:
virtual ~VrBrowserInterface() {}
- virtual void ContentSurfaceChanged(jobject surface) {}
- virtual void GvrDelegateReady() {}
- virtual void UpdateGamepadData(device::GvrGamepadData) {}
- virtual void AppButtonGesturePerformed(UiInterface::Direction direction) {}
- virtual void OnAppButtonClicked() {}
+ virtual void ContentSurfaceChanged(jobject surface) = 0;
+ virtual void GvrDelegateReady() = 0;
+ virtual void UpdateGamepadData(device::GvrGamepadData) = 0;
+ virtual void AppButtonGesturePerformed(UiInterface::Direction direction) = 0;
+ virtual void AppButtonClicked() = 0;
virtual void ProcessContentGesture(
- std::unique_ptr<blink::WebInputEvent> event) {}
- virtual void ForceExitVr() {}
+ std::unique_ptr<blink::WebInputEvent> event) = 0;
+ virtual void ForceExitVr() = 0;
virtual void RunVRDisplayInfoCallback(
const base::Callback<void(device::mojom::VRDisplayInfoPtr)>& callback,
- device::mojom::VRDisplayInfoPtr* info) {}
- virtual void OnContentPaused(bool enabled) {}
+ device::mojom::VRDisplayInfoPtr* info) = 0;
+ virtual void OnContentPaused(bool enabled) = 0;
};
} // namespace vr_shell
« no previous file with comments | « chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc ('k') | chrome/browser/android/vr_shell/vr_gl_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698