[Payment Request] Refactors PaymentRequestCoordinator.

ios/chrome/browser/ui/payments/payment_request_coordinator.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_UI_PAYMENTS_PAYMENT_REQUEST_COORDINATOR_H_
 #define IOS_CHROME_BROWSER_UI_PAYMENTS_PAYMENT_REQUEST_COORDINATOR_H_
 
 #import <UIKit/UIKit.h>
 
 #include "base/ios/block_types.h"
@@ skipping 16 matching lines @@
 class ChromeBrowserState;
 }  // namespace ios
 
 namespace payments {
 struct PaymentAddress;
 }  // namespace payments
 
 namespace web {
 class PaymentDetails;
 class PaymentShippingOption;
-class PaymentResponse;
 }  // namespace web
 
 @class PaymentRequestCoordinator;
 
 // Delegate protocol for PaymentRequestCoordinator.
 @protocol PaymentRequestCoordinatorDelegate<NSObject>
 
 // Notifies the delegate that the user has canceled the payment request.
 - (void)paymentRequestCoordinatorDidCancel:
     (PaymentRequestCoordinator*)coordinator;
 
 // Notifies the delegate that the user has selected to go to the card and
 // address options page in Settings.
 - (void)paymentRequestCoordinatorDidSelectSettings:
     (PaymentRequestCoordinator*)coordinator;
 
-// Notifies the delegate that the user has confirmed the payment request.
+// Notifies the delegate that the user has completed the payment request.
 - (void)paymentRequestCoordinator:(PaymentRequestCoordinator*)coordinator
-    didConfirmWithPaymentResponse:(web::PaymentResponse)paymentResponse;
+        didCompletePaymentRequest:(PaymentRequest*)paymentRequest
+                             card:(const autofill::CreditCard&)card
+                              cvc:(const base::string16&)cvc;

[marq (ping after 24h), 2017/05/09 09:00:33]

The rules for using initialisms and other abbreviations in Objective-C are (1)
if they are used, they should be in uppercase (URL, HTTP, etc), and (2) they
shouldn't be used unless they are very widely-understood software engineering
terms.

So I would prefer that you s/cvc/verfificationCode/.

[macourteau, 2017/05/09 15:21:52]

Done.

 
 // Notifies the delegate that the user has selected a shipping address.
 - (void)paymentRequestCoordinator:(PaymentRequestCoordinator*)coordinator
          didSelectShippingAddress:(payments::PaymentAddress)shippingAddress;
 
 // Notifies the delegate that the user has selected a shipping option.
 - (void)paymentRequestCoordinator:(PaymentRequestCoordinator*)coordinator
           didSelectShippingOption:(web::PaymentShippingOption)shippingOption;
 
 @end
@@ skipping 46 matching lines @@
 // Called when a credit card has been successfully unmasked. Note that |card|
 // may be different from what's returned by the selected_credit_card() method of
 // |paymentRequest|, because CVC unmasking process may update the credit card
 // number and expiration date.
 - (void)fullCardRequestDidSucceedWithCard:(const autofill::CreditCard&)card
                                       CVC:(const base::string16&)cvc;
 
 @end
 
 #endif  // IOS_CHROME_BROWSER_UI_PAYMENTS_PAYMENT_REQUEST_COORDINATOR_H_