Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2866623002: Include limits.h on Android to work around NDK deficiency (Closed)

Created:
3 years, 7 months ago by hans
Modified:
3 years, 7 months ago
Reviewers:
foolip, stevef
CC:
chromium-reviews
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include limits.h on Android to work around NDK deficiency Until very recent versions, the NDK failed to define SIZE_MAX in the correct header; including limits.h works around this. This was committed upstream in https://git.xiph.org/?p=flac.git;a=commit;h=b762a20ace7c7771f87f63478bcee3cf51268cff BUG=none R=foolip@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/flac/+/7d0f5b3a173ffe98db08057d1f52b7787569e0a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M include/share/compat.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/libFLAC/md5.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/libFLAC/memory.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hans
See b/37545539 for more context. Steve: Please confirm this fixes the problem on your end. ...
3 years, 7 months ago (2017-05-05 00:19:04 UTC) #2
stevefung
On 2017/05/05 00:19:04, hans wrote: > See b/37545539 for more context. > > Steve: Please ...
3 years, 7 months ago (2017-05-05 00:25:18 UTC) #3
foolip
lgtm
3 years, 7 months ago (2017-05-05 11:22:46 UTC) #4
hans
3 years, 7 months ago (2017-05-05 15:17:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d0f5b3a173ffe98db08057d1f52b7787569e0a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698