Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 2866613002: EQT: Change Expected Queuing Time from per-second to sliding window (Closed)
Patch Set: uma report per window duration; sliding window include the starting points Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
index f2f6239d3c1d6061ea0127e300209ff10c71f3ad..5ab38c32e8f45da133be1ede4652a84e52ea340d 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
@@ -3801,6 +3801,32 @@ TEST_F(RendererSchedulerImplTest, UnresponsiveMainThread) {
scheduler_->MainThreadSeemsUnresponsive(responsiveness_threshold()));
}
+// As |responsiveness_threshold| == expected queueing time threshold == 0.2s,
+// for a task shorter than the length of the window (1s), the critical value of
+// the length of task x can be calculated by (x/2) * (x/1) = 0.2, in which x =
+// 0.6324.
+TEST_F(RendererSchedulerImplTest, UnresponsiveMainThreadAboveThreshold) {
+ EXPECT_FALSE(
+ scheduler_->MainThreadSeemsUnresponsive(responsiveness_threshold()));
+
+ AdvanceTimeWithTask(0.64);
+ EXPECT_TRUE(
+ scheduler_->MainThreadSeemsUnresponsive(responsiveness_threshold()));
+}
+
+// As |responsiveness_threshold| == expected queueing time threshold == 0.2s,
+// for a task shorter than the length of the window (1s), the critical value of
+// the length of task x can be calculated by (x/2) * (x/1) = 0.2, in which x =
+// 0.6324.
+TEST_F(RendererSchedulerImplTest, ResponsiveMainThreadBelowThreshold) {
+ EXPECT_FALSE(
+ scheduler_->MainThreadSeemsUnresponsive(responsiveness_threshold()));
+
+ AdvanceTimeWithTask(0.63);
+ EXPECT_FALSE(
+ scheduler_->MainThreadSeemsUnresponsive(responsiveness_threshold()));
+}
+
TEST_F(RendererSchedulerImplTest, ResponsiveMainThreadDuringTask) {
EXPECT_FALSE(
scheduler_->MainThreadSeemsUnresponsive(responsiveness_threshold()));

Powered by Google App Engine
This is Rietveld 408576698