third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc - Issue 2866613002: EQT: Change Expected Queuing Time from per-second to sliding window

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2866613002: EQT: Change Expected Queuing Time from per-second to sliding window (Closed)

Patch Set: Initilize buffer size at initialization; add documentation to ratio and add illustration of sliding… Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator.cc ('K') | « third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

index f3369ecb1d37ebb10a89938fb290bf28bd1e0067..55812bc3b2f9c50d99ee83ba454211d0309f7805 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

@@ -106,7 +106,7 @@ RendererSchedulerImpl::RendererSchedulerImpl(

base::Unretained(this)),

helper_.ControlTaskQueue()),

seqlock_queueing_time_estimator_(

- QueueingTimeEstimator(this, base::TimeDelta::FromSeconds(1))),

+ QueueingTimeEstimator(this, base::TimeDelta::FromSeconds(1), 1)),

tdresser 2017/05/08 17:58:15 We'll want this to behave the same with a step siz

Liquan (Max) Gu 2017/05/10 15:14:21 Does 5 steps per window sound good?

tdresser 2017/05/10 18:54:31 Hmmm. Eventually, we'll want something much greate

main_thread_only_(this,

compositor_task_queue_,

helper_.scheduler_tqm_delegate().get(),

@@ -1670,7 +1670,7 @@ bool RendererSchedulerImpl::MainThreadSeemsUnresponsive(

base::TimeDelta estimated_queueing_time;

bool can_read = false;

- QueueingTimeEstimator::State queueing_time_estimator_state;

+ QueueingTimeEstimator::State queueing_time_estimator_state(1);

tdresser 2017/05/08 17:58:14 Same as above.

Liquan (Max) Gu 2017/05/10 15:14:21 It seems unnecessary to define it seperately.

tdresser 2017/05/10 18:54:31 Acknowledged.

base::subtle::Atomic32 version;

seqlock_queueing_time_estimator_.seqlock.TryRead(&can_read, &version);