runtime/vm/kernel_binary.cc - Issue 2866593003: Add an optional bound to type parameter references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/kernel_binary.cc

Issue 2866593003: Add an optional bound to type parameter references (Closed)

Patch Set: Don't leak the bound if it ever becomes non-null Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/kernel_binary.cc

diff --git a/runtime/vm/kernel_binary.cc b/runtime/vm/kernel_binary.cc

index 80d293980c68d54802b7ef265a7383e82dd8de0d..55cee46d294e04bf29850131a0b9a4788703499d 100644

--- a/runtime/vm/kernel_binary.cc

+++ b/runtime/vm/kernel_binary.cc

@@ -1486,6 +1486,8 @@ TypeParameterType* TypeParameterType::ReadFrom(Reader* reader) {

TypeParameterType* type = new TypeParameterType();

type->parameter_ =

reader->helper()->type_parameters().Lookup(reader->ReadUInt());

+ // There is an optional promoted bound, currently ignored.

+ delete reader->ReadOptional<DartType>();

return type;

}

« no previous file with comments | « pkg/kernel/lib/binary/ast_to_binary.dart ('k') | no next file » | no next file with comments »